Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Speed up unnecessarily slow "prep" plunger motions #16022

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

andySigler
Copy link
Contributor

Overview

The "prep" plunger speeds were originally set to the slower aspirate/dispense speeds in an overly cautious attempt at avoiding moving inner-tip droplets around.

We had an oversight, however, in that moving droplets is ONLY a concern after a blow-out. Any other time, there is not a risk of droplets inside the tip.

Therefore, we can always move the plunger safely at max speed (without affecting pipetting performance at all), except under the following situation:

  1. Tip is attached
  2. Plunger position is below bottom (meaning a blow-out has occurred)

Happy to discuss implications and concerns if there are any.

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

Copy link
Contributor

@ryanthecoder ryanthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andySigler andySigler merged commit da7918e into edge Aug 19, 2024
21 checks passed
@andySigler andySigler deleted the api-fix-speed-up-unnecessarily-slow-plunger-prep branch August 19, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants