Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components, protocol-designer): wire up create file pages and make ListItemCustomize #15994

Merged
merged 9 commits into from
Aug 20, 2024

Conversation

jerader
Copy link
Collaborator

@jerader jerader commented Aug 14, 2024

closes AUTH-647 AUTH-664 AUTH-668

Overview

Sorry, should have split this out into a few PRs - this PR does 2 things:

  1. create ListItemCustomize component
  2. add logic to selecting pipettes, modules and fixtures in the create file wizard

NOTE: there is still follow up work required including:

  1. writing unit tests
  2. disabling the proceed button and adding the snackbar if there is no slot available for fixtures and modules
  3. and more things like modals
Screen.Recording.2024-08-14.at.08.41.43.mov

Test Plan and Hands on Testing

Go through the create file wizard with the redesign ff turned on. Make sure you can select pipettes, modules, and fixtures and remove them. There is still follow up work to be done!

Changelog

  • add logic for selecting pipettes, modules and fixtures
  • make customize child component and add to story

Review requests

see test plan

Risk assessment

low

@jerader jerader requested review from a team as code owners August 14, 2024 12:41
@jerader jerader requested review from mjhuff, koji and ncdiehl11 and removed request for a team August 14, 2024 12:41
@jerader
Copy link
Collaborator Author

jerader commented Aug 14, 2024

tickets for follow up work:

  1. unit tests https://opentrons.atlassian.net/browse/AUTH-669
  2. unavailable slot disable button https://opentrons.atlassian.net/browse/AUTH-670

@jerader jerader removed request for a team and mjhuff August 14, 2024 13:00
@jerader jerader requested a review from koji August 15, 2024 13:03
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like Koji went through code quality/style. Works as expected, nice!

@jerader jerader merged commit c40859f into edge Aug 20, 2024
48 checks passed
@jerader jerader deleted the components_customize branch August 20, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants