-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components, protocol-designer): wire up create file pages and make ListItemCustomize #15994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerader
requested review from
mjhuff,
koji and
ncdiehl11
and removed request for
a team
August 14, 2024 12:41
tickets for follow up work:
|
koji
reviewed
Aug 14, 2024
components/src/atoms/ListItem/ListItemChildren/ListItemCustomize.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Aug 14, 2024
protocol-designer/src/pages/CreateNewProtocolWizard/PipetteInfoItem.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Aug 14, 2024
protocol-designer/src/pages/CreateNewProtocolWizard/SelectModules.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Aug 14, 2024
koji
reviewed
Aug 14, 2024
koji
reviewed
Aug 20, 2024
components/src/atoms/ListItem/ListItemChildren/ListItemCustomize.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Aug 20, 2024
components/src/atoms/ListItem/ListItemChildren/ListItemCustomize.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Aug 20, 2024
koji
reviewed
Aug 20, 2024
koji
reviewed
Aug 20, 2024
protocol-designer/src/pages/CreateNewProtocolWizard/PipetteInfoItem.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Aug 20, 2024
protocol-designer/src/pages/CreateNewProtocolWizard/PipetteInfoItem.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Aug 20, 2024
protocol-designer/src/pages/CreateNewProtocolWizard/PipetteInfoItem.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Aug 20, 2024
protocol-designer/src/pages/CreateNewProtocolWizard/SelectFixtures.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Aug 20, 2024
protocol-designer/src/pages/CreateNewProtocolWizard/SelectFixtures.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Aug 20, 2024
protocol-designer/src/pages/CreateNewProtocolWizard/SelectModules.tsx
Outdated
Show resolved
Hide resolved
koji
reviewed
Aug 20, 2024
koji
reviewed
Aug 20, 2024
jerader
force-pushed
the
components_customize
branch
from
August 20, 2024 13:16
0241101
to
817c21e
Compare
jerader
force-pushed
the
components_customize
branch
from
August 20, 2024 14:19
67961d3
to
9766f0d
Compare
ncdiehl11
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like Koji went through code quality/style. Works as expected, nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes AUTH-647 AUTH-664 AUTH-668
Overview
Sorry, should have split this out into a few PRs - this PR does 2 things:
ListItemCustomize
componentNOTE: there is still follow up work required including:
Screen.Recording.2024-08-14.at.08.41.43.mov
Test Plan and Hands on Testing
Go through the create file wizard with the redesign ff turned on. Make sure you can select pipettes, modules, and fixtures and remove them. There is still follow up work to be done!
Changelog
Review requests
see test plan
Risk assessment
low