add 'length' to InlineAssembly.externalReferences[].suffix

OpenZeppelin · Aug 26, 2024 · 3518d5b · 3518d5b
1 parent 99d606d
commit 3518d5b
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,7 @@
 ### 0.4.58 (2024-08-26)
 
 - Fixed `YulFunctionDefinition.parameters` and `returnVariables`: made optional, used when empty.
+- Fixed `InlineAssembly.externalReferences[].suffix`: added `'length'` option.
 
 ### 0.4.57 (2024-07-16)
 

diff --git a/scripts/build-schema.js b/scripts/build-schema.js
@@ -498,7 +498,7 @@ const schema = {
           isSlot: boolean,
           src: ref('SourceLocation'),
           valueSize: integer,
-          suffix: optional(literal('slot', 'offset')),
+          suffix: optional(literal('slot', 'offset', 'length')),
         })),
         flags: optional(array(literal('memory-safe'))),
       },

diff --git a/test/sources/asm-0.7.5.sol b/test/sources/asm-0.7.5.sol
@@ -0,0 +1,9 @@
+pragma solidity >=0.7.5;
+
+contract Asm {
+    function foo(bytes calldata b) external {
+        assembly {
+            let z := b.length
+        }
+    }
+}
diff --git a/test/sources/asm-0.7.sol b/test/sources/asm-0.7.sol
@@ -3,7 +3,7 @@ pragma solidity >=0.7;
 contract Asm {
     uint s;
 
-    function foo() external {
+    function foo(bytes calldata b) external {
         assembly {
             let x := s.slot
             let y := s.offset