-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Add --requireReference
option
#900
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericglau
changed the title
CLI: Add
Add Oct 19, 2023
requireReference
optionrequireReference
option for CLI
Amxx
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ericglau
changed the title
Add
CLI: Add Oct 20, 2023
requireReference
option for CLI--requireReference
option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
--requireReference
flag to make the CLI run in an upgrade-oritented mode, where it expects the contract specified by--contract
to have a reference for storage layout comparisons.This flag can be used when we want to ensure that storage layout checks are run.
When this option is enabled, either the
--reference <REFERENCE_CONTRACT>
flag must be provided as well, or the contract must have a@custom:oz-upgrades-from <REFERENCE_CONTRACT>
annotation, so that storage layout comparisons can occur.