Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Add --requireReference option #900

Merged
merged 14 commits into from
Oct 20, 2023

Conversation

ericglau
Copy link
Member

Adds a --requireReference flag to make the CLI run in an upgrade-oritented mode, where it expects the contract specified by --contract to have a reference for storage layout comparisons.

This flag can be used when we want to ensure that storage layout checks are run.

When this option is enabled, either the --reference <REFERENCE_CONTRACT> flag must be provided as well, or the contract must have a @custom:oz-upgrades-from <REFERENCE_CONTRACT> annotation, so that storage layout comparisons can occur.

@ericglau ericglau requested a review from a team October 19, 2023 16:20
@ericglau ericglau changed the title CLI: Add requireReference option Add requireReference option for CLI Oct 19, 2023
Copy link
Contributor

@Amxx Amxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericglau ericglau changed the title Add requireReference option for CLI CLI: Add --requireReference option Oct 20, 2023
@ericglau ericglau merged commit 46c3cff into OpenZeppelin:master Oct 20, 2023
7 of 8 checks passed
@ericglau ericglau deleted the requireReference branch October 20, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants