Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade slang to 0.18.3 #1100

Closed

Conversation

OmarTawfik
Copy link

@OmarTawfik OmarTawfik commented Nov 14, 2024

The newest version includes many performance improvements, and adds WASM support. It also adds a bunch of requested public APIs.

This allows importing Slang from any WASM-compatible environment (NodeJS), at the cost of using ESM (or using await import() from CJS). That turns the calling utility makeNamespacedInput() to be async. Thoughts? Concerns?

Please let me know if I need to verify/run anything else.

Copy link

socket-security bot commented Nov 14, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@nomicfoundation/[email protected] None +1 2.78 MB nomic-foundation-publisher

🚮 Removed packages: npm/@nomicfoundation/[email protected], npm/[email protected]

View full report↗︎

@OmarTawfik OmarTawfik changed the title upgrade slang to latest version upgrade slang to 0.18.3 Nov 14, 2024
The newest version includes many performance improvements, and adds WASM support. It also adds a bunch of requested public APIs.

This allows importing Slang from any WASM-compatible environment (NodeJS), at the cost of using ESM (or using `await import()` from CJS).
That turns the calling utility `makeNamespacedInput()` to be `async`.

Please let me know if I need to verify/run anything else.
@OmarTawfik OmarTawfik marked this pull request as ready for review November 15, 2024 05:01
@OmarTawfik
Copy link
Author

cc @ericglau @frangio

@ericglau
Copy link
Member

Thank you @OmarTawfik for this PR!

The suggestions and changes look great, however I would like to make some slight adjustments in the upgrades-core package's exported functions to avoid breaking changes. I will continue this in #1102 and will close this original PR. Thanks!

@ericglau ericglau closed this Nov 20, 2024
@OmarTawfik OmarTawfik deleted the upgrade-slang branch November 22, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants