Support TypeChain in deploy and upgrade proxy functions - continuation of work done on #535 #1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onProxy, deployBeacon, upgradeProxy, upgradeBeacon, and forceImport functions
robertmagier
force-pushed
the
feat/deploy-upgrade-proxy-contract-return-type
branch
from
1e452b5
to
837272c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of work done on #535 by frimoldi.
See #325 and #1082.
Correctly returns type on: deployProxy, deployContract, deployBeaconProxy, deployBeacon, upgradeProxy, upgradeBeacon, and forceImport functions
Not sure if forceImport returned type is OK. I will apprieciate some guidance here.