Add missing docstrings #5311
Open
Add missing docstrings #5311
+31
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ernestognw
commented
Nov 20, 2024
contracts/governance/extensions/GovernorCountingOverridable.sol
Outdated
Show resolved
Hide resolved
cairoeth
reviewed
Nov 21, 2024
cairoeth
reviewed
Nov 21, 2024
Co-authored-by: cairo <[email protected]>
Co-authored-by: cairo <[email protected]>
Amxx
approved these changes
Nov 21, 2024
cairoeth
approved these changes
Nov 21, 2024
Amxx
reviewed
Nov 22, 2024
| @@ -63,6 +69,12 @@ interface IERC7579Validator is IERC7579Module { | |||
| ) external view returns (bytes4); | |||
| } | |||
|
|
|||
| /** | |||
| * @dev ERC-7579 Executor. | |||
There was a problem hiding this comment.
This is IERC7579Hook.
Hooks module are type id 4 and Execution modules are type id 2. So I'm guessing there is a confusion here
Suggested change
| * @dev ERC-7579 Executor. | |
| * @dev ERC-7579 Hooks module (type 4). |
Amxx
reviewed
Nov 22, 2024
| @@ -36,6 +37,11 @@ interface IERC7579Module { | |||
| function isModuleType(uint256 moduleTypeId) external view returns (bool); | |||
| } | |||
|
|
|||
| /** | |||
| * @dev ERC-7579 Validator. | |||
There was a problem hiding this comment.
Suggested change
| * @dev ERC-7579 Validator. | |
| * @dev ERC-7579 Validation module (type 1). |
Amxx
reviewed
Nov 22, 2024
| /** | ||
| * @dev ERC-7579 Account Config. | ||
| * | ||
| * Exposes information that identifies the account, supported modules and capabilities. |
There was a problem hiding this comment.
Suggested change
| * Exposes information that identifies the account, supported modules and capabilities. | |
| * Accounts should implement this interface to exposes information that identifies the account, supported modules and capabilities. |
Amxx
reviewed
Nov 22, 2024
| /** | ||
| * @dev ERC-7579 Module Config. | ||
| * | ||
| * Allows an account to install and uninstall modules. |
There was a problem hiding this comment.
Suggested change
| * Allows an account to install and uninstall modules. | |
| * Accounts should implement this interface to allows installing and uninstalling modules. |
Amxx
reviewed
Nov 22, 2024
Comment on lines
+109
to
+111
| * @dev Smart Account execution according to ERC-7579. | ||
| * | ||
| * To implement ERC-7579 modules, smart accounts must implement this interface. |
There was a problem hiding this comment.
Suggested change
| * @dev Smart Account execution according to ERC-7579. | |
| * | |
| * To implement ERC-7579 modules, smart accounts must implement this interface. | |
| * @dev ERC-7579 Execution. | |
| * | |
| * Accounts should implement this interface so that the Entrypoint and ERC-7579 modules can execute operations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes L-09
PR Checklist
npx changeset add)