Document voting counting until casted in GovernorCountingOverridable

[ernestognw]

Fixes L-04

Although we're not changing the code, it's true that more explicit documentation is required

PR Checklist

• Tests
• Documentation
• Changeset entry (run npx changeset add)

[changeset-bot]

⚠️ No Changeset found

Latest commit: 7859407

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[Amxx]

There is a missunderstanding here.

Casting an override does trigger _countOverride, which will update the votes count for the proposal ID. This will immidiatly affect the result of the vote, and count toward quorum.

It also triggers _tallyUpdated, which may may trigger quorum related operations, such as the one in GovernorPreventLateQuorum.

This means that vote override are fully and immedialty accounted, regardless of the actions of the delegate (which may never vote).

[ernestognw]

Right, I removed the NatSpec at the top of the contract and kept the two notes.