Enhancements #36
Open
Enhancements #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We allow overloading the pv-addons-version to 'force-emulate' to attach the USB device to the stubdom. The stubdom can then use the emulated USB to passthrough the device. This is a step toward allowing USB passthrough without pv addons. Signed-off-by: Jason Andryuk <[email protected]>
A 'running' rule will check for matching devices and VMs, but only apply the rule to the first running VM found in policy search order. It will skip the assignment for shutdown VMs. *This is a change from the previous first match only configuration.* Prior to this new command, boot-time plugging devices required an 'always' or 'default' rule with a vm uuid. However, that meant that only the first entry in usb-rules would work for hotplug a device after boot - a second VM could not be matched. A generic 'allow' rule for a device would hotplug to any VM, but it would not attach on boot. The new rule will allow handling rules for the same vid:pid, but with differing uuids. The first match rule meant rule search would stop on whichever VM came first. Here we want to skip rules for non-running VMs so the Nth VM can get the device assignment if it is running and the others are not. Signed-off-by: Jason Andryuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two separate enhancements.
The first switches the PV passthrough from the guest to instead passtrough to the stubdom. openxt-vusb can be installed in the stubdom, and then QEMU emulation can get the device into the guest.
The second expands the policy to allow a new "running" rule. The use case is you have N VMs, but you only run one at a time. You want the USB device to get passed through at bootup or hotplug to whichever one VM is running. The existing rules wouldn't allow that.