Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
The
this.WindowCovering.CurrentPosition
values appear to be inverted, elsewhere in the code this is accounted for by a subtraction from 100. If the curtain is at 3%, setting theset_max
value to 5% or 95% does not result in a closed state.💡 Proposed solution
Adjust the logic so that the closed state sets the
CurrentPosition
value to0
instead of100
.