Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix min max states #1133

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Conversation

dnicolson
Copy link
Collaborator

♻️ Current situation

The this.WindowCovering.CurrentPosition values appear to be inverted, elsewhere in the code this is accounted for by a subtraction from 100. If the curtain is at 3%, setting the set_max value to 5% or 95% does not result in a closed state.

💡 Proposed solution

Adjust the logic so that the closed state sets the CurrentPosition value to 0 instead of 100.

@github-actions github-actions bot added enhancement New feature or request latest labels Dec 8, 2024
@donavanbecker donavanbecker changed the base branch from latest to beta-4.1.6 December 11, 2024 03:20
@github-actions github-actions bot added the beta label Dec 11, 2024
@donavanbecker donavanbecker merged commit 9869884 into OpenWonderLabs:beta-4.1.6 Dec 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta enhancement New feature or request latest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants