Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate bus utils #207

Merged
merged 2 commits into from
Dec 28, 2023
Merged

deprecate bus utils #207

merged 2 commits into from
Dec 28, 2023

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Dec 28, 2023

companion to OpenVoiceOS/ovos-bus-client#68

#205 continued

@JarbasAl JarbasAl mentioned this pull request Dec 28, 2023
15 tasks
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 120 lines in your changes are missing coverage. Please review.

Comparison is base (92f80e1) 31.92% compared to head (40e6630) 31.97%.

❗ Current head 40e6630 differs from pull request most recent head a4195e6. Consider uploading reports for the commit a4195e6 to get more accurate results

Files Patch % Lines
ovos_utils/messagebus.py 6.95% 107 Missing ⚠️
ovos_utils/enclosure/mark1/__init__.py 0.00% 2 Missing ⚠️
ovos_utils/enclosure/mark1/eyes/__init__.py 0.00% 2 Missing ⚠️
ovos_utils/enclosure/mark1/faceplate/__init__.py 0.00% 2 Missing ⚠️
ovos_utils/enclosure/mark1/faceplate/animations.py 0.00% 2 Missing ⚠️
...ls/enclosure/mark1/faceplate/cellular_automaton.py 0.00% 2 Missing ⚠️
ovos_utils/enclosure/mark1/faceplate/icons.py 0.00% 2 Missing ⚠️
ovos_utils/skills/settings.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #207      +/-   ##
==========================================
+ Coverage   31.92%   31.97%   +0.04%     
==========================================
  Files          49       49              
  Lines        6524     6537      +13     
==========================================
+ Hits         2083     2090       +7     
- Misses       4441     4447       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit a6432fb into dev Dec 28, 2023
9 checks passed
@JarbasAl JarbasAl deleted the refactor/bus_utils branch December 28, 2023 23:25
@github-actions github-actions bot mentioned this pull request Dec 28, 2023
emphasize pushed a commit to emphasize/ovos-utils that referenced this pull request Dec 30, 2023
* deprecate bus utils

* deprecate bus utils
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant