Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix:more intent formulations #14
base: dev
Are you sure you want to change the base?
fix:more intent formulations #14
Changes from 1 commit
a766d9c
b4ad096
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: Antonym intent expanded with diverse formulations, but contains a duplicate.
The additions to the "antonym.intent" array provide an excellent variety of ways to ask about antonyms or opposites. This expansion aligns well with the PR objective of enhancing intents with more sample formulations.
However, there's a duplicate entry that should be removed:
"what are the antonyms of {query}", "what is a antonym of {query}", "what is the antonym of {query}", -"what are the antonyms of {query}", "what is an antonym for {query}",
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: Holonym intent expanded with diverse formulations, but some phrases may be misplaced.
The additions to the "holonym.intent" array provide an excellent variety of ways to ask about holonyms or larger terms that include the query. This expansion aligns well with the PR objective of enhancing intents with more sample formulations.
However, some phrases seem more related to hypernyms than holonyms:
Consider reviewing these phrases and possibly moving them to the "hypernym.intent" section to maintain accuracy in intent classification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: New lemma intent added with diverse formulations, but contains duplicates.
The addition of the "lemma.intent" array is a valuable expansion, providing various ways to ask about lemmas and related word forms. This new intent aligns well with the PR objective of enhancing the system's language-related capabilities.
However, there are duplicate entries that should be removed:
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM: Definition intent expanded with diverse formulations, but contains a duplicate.
The additions to the "definition.intent" array provide an excellent variety of ways to ask about the definition or meaning of a term. This expansion aligns well with the PR objective of enhancing intents with more sample formulations.
However, there's a duplicate entry that should be removed:
"what is a {query}", "what is the definition of {query}", "can you tell me what a {query} is", "what does {query} mean", "give me the definition of {query}", "what is the meaning of {query}", "how would you define {query}", "could you explain what {query} is", -"what is a {query}", "can you describe {query}", "what do you call a {query}"
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue: Incorrect terminology in lemma intent.
The "lemma.intent" is using the term "sinônimo" (synonym) instead of "lema" (lemma). These are different linguistic concepts and could lead to confusion.
Consider changing the intent to:
This change ensures the intent accurately reflects the concept of lemma rather than synonym.