Improve Russian translation #57
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #57 +/- ##
=======================================
Coverage 26.14% 26.14%
=======================================
Files 8 8
Lines 1090 1090
=======================================
Hits 285 285
Misses 805 805
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| {{day}} будет {{condition}}, с максимумом {{temp_max}} и минимумом {{temp_min}} | ||
| {{day}}, {{location}} самая высокая температура будет {{temp_max}} и самая низкая - {{temp_min}}, с {{condition}} погодными условиями | ||
| Прогноз погоды для {{day}} {{temp_max}} как высокая температура и {{temp_min}} как низкая | ||
| {day} будет {condition}, температура поднимется до {temp_max} и опустится до {temp_min} |
There was a problem hiding this comment.
The variables temp_max/temp_min have to be swapped with high_temperature/ low_temperature. (in general)
There was a problem hiding this comment.
Good catch! It was a file with a misspelled name. Apparently, that's why the old variables were still there. I deleted it completely.
| Будет легкий ветер, идущий от {direction} {day} в {speed} {speed_unit}. | ||
| Будет не очень ветрено {day} | ||
| {day} будет легкий {direction} ветер, {speed} {speed_unit} | ||
| {day} будет не очень ветрено |
There was a problem hiding this comment.
while the missing {location} in some of the dialogs is not a big deal (as you are specifically asking for a location and is more of a confirmation), do you want to omit the speed, speed_unit and direction here?
50-50 chance that cant be influenced.
There was a problem hiding this comment.
It is the same in the en-us translation, so I kept it as is. There should probably be some general style guide for all languages.
|
we should rebase this so it can get integrated in the new translations framework, after merging we can handle any future fixes on the translation ui |
No description provided.