fix: choose joke type per language support

README.md

@@ -32,3 +32,4 @@ Brighten your day with dad humor.
 - Jokes from [The Internet Chuck Norris DB (ICNDB)](http://www.icndb.com/) provided under CC BY-SA 3.0
 - programmer jokes from [stackoverflow](http://stackoverflow.com/questions/234075/what-is-your-best-programmer-joke?page=4&tab=votes#tab-top) provided under CC BY-SA 3.0
 - [Blagues-API](https://github.com/Blagues-API/blagues-api/) (french)
+- [Puntuguese dataset](https://github.com/Superar/Puntuguese) (portuguese puns)

__init__.py

@@ -21,20 +21,28 @@ class JokingSkill(OVOSSkill):
 
     @intent_handler("joke.intent")
     def handle_joke(self, message: Optional[Message] = None) -> None:
-        self.speak_dialog("general_jokes")
+        # TODO - refactor this once lang support is more uniform
+        if self.lang.startswith("pt"):
+            self.speak_dialog("puns")
+        elif self.lang.split("-")[0] in ["cs", "es", "eu", "gl", "hu", "it", "pl", "sv"]:
+            self.speak_dialog("dev_jokes")
+        else:
+            self.speak_dialog("general_jokes")
 
     @intent_handler("search_joke.intent")
     def handle_search_joke(self, message: Message) -> None:
         category = message.data["search"].lower()
         self.log.debug("joke search: %s", category)
 
         # TODO self.voc_match more joke types
-        # special handling for chuck norris jokes
+        # TODO allow blacklisting some categories in settings.json (kid friendly setting by default)
         if self.voc_match(voc_filename="ChuckNorris", utt=category, lang=self.lang):
             self.speak_dialog("chuck_norris_jokes")
         elif self.voc_match(voc_filename="Dad", utt=category, lang=self.lang):
             self.speak_dialog("dad_jokes")
         elif self.voc_match(voc_filename="Programmer", utt=category, lang=self.lang):
             self.speak_dialog("dev_jokes")
+        elif self.voc_match(voc_filename="Pun", utt=category, lang=self.lang):
+            self.speak_dialog("puns")
         else:
             self.speak_dialog("no_joke", {"search": category})

locale/en-us/Pun.voc

@@ -0,0 +1,3 @@
+pun
+Wordplay
+quip

locale/pt-pt/Pun.voc

@@ -0,0 +1,3 @@
+Duplo sentido
+trocadilho
+Jogo de palavras

translations/en-us/vocabs.json

@@ -6,6 +6,11 @@
     "ChuckNorris.voc": [
         "chuck norris"
     ],
+    "Pun.voc": [
+        "pun",
+        "Wordplay",
+        "quip"
+    ],
     "Dad.voc": [
         "Dad"
     ]