OpenVoiceOS · JarbasAl · Oct 15, 2024 · Oct 15, 2024 · Oct 15, 2024
diff --git a/README.md b/README.md
@@ -1,18 +1,32 @@
-# Finished Booting
+# Finished Booting Skill
 
 ## Summary
 
-Skill to speak when OVOS is ready
+The Finished Booting skill provides a notification when OpenVoiceOS (OVOS) has fully started and all core services are ready. This notification can be spoken to the user or simply logged, depending on the user's preferences.
 
 ## Description
 
-When OpenVoiceOS is started or restarted, this skill will speak a notification to the
-user. This speech can be enabled/disabled by intent.
+This skill ensures that users are informed when OVOS has completed booting and all essential services (such as network, GUI, and others) are ready for use. It provides a customizable ready notification that can be enabled or disabled via voice commands. The notification can be delivered either via a spoken message, sound, or visual cues on connected devices.
+
+### Key Features:
+- Monitors system readiness by checking core services like network, internet, and GUI.
+- Notifies the user when OVOS is fully ready.
+- Allows users to enable or disable the ready notification via voice intents.
+- Configurable options for spoken readiness notifications and sound effects.
+
+## Voice Commands
+
+- **Enable Ready Notifications**: Activates the spoken notification when OVOS is ready.
+  - Example: "Enable ready notifications."
+
+- **Disable Ready Notifications**: Deactivates the spoken notification.
+  - Example: "Disable load speech."
 
 ## Examples
 
 - "Enable ready notifications."
-- "Disable load speech."
+- "Disable ready speech."
+- "Is the system ready?"
 
 ## Credits
 [NeonGeckoCom](https://github.com/NeonGeckoCom/skill-core_ready)

diff --git a/__init__.py b/__init__.py
@@ -59,13 +59,20 @@ def is_device_ready(self) -> bool:
         is_ready = False
         # Different setups will have different needs
         # eg, a server does not care about audio
-        # internet -> device is connected to the internet - NOT IMPLEMENTED
+        # internet -> device is connected to the internet
+        # network -> device is connected to the internet
+        # gui_connected -> a gui client connected to the gui socket
+
+        # any service using ProcessStatus class can also be added to ready_settings
         # skills -> skills reported ready
         # speech -> stt reported ready
         # audio -> audio playback reported ready
-        # gui -> gui websocket reported ready - NOT IMPLEMENTED
-        # enclosure -> enclosure/HAL reported ready - NOT IMPLEMENTED
+        # gui -> gui websocket reported ready
+        # PHAL -> enclosure/HAL reported ready
+
         # TODO - allow requiring specific skills to be fully loaded
+        # skills might be loaded by core or run standalone, we should standardize how this is checked via bus
+        # perhaps ProcessStatus with skill_id ?
         services = {k: False for k in
                     self.settings.get("ready_settings", ["skills", "speech", "audio"])}
         start = monotonic()
@@ -92,16 +99,15 @@ def check_services_ready(self, services):
             if rdy:
                 # already reported ready
                 continue
-            if ser in ["gui", "enclosure"]:
-                # not implemented
-                services[ser] = True
-                continue
-            elif ser in ["network_skills"]:
+            if ser in ["network_skills", "network"]:
                 services[ser] = self._network_event.is_set()
                 continue
-            elif ser in ["internet_skills"]:
+            elif ser in ["internet_skills", "internet"]:
                 services[ser] = self._connected_event.is_set()
                 continue
+            elif ser in ["gui_connected"]:
+                services[ser] = self._gui_event.is_set()
+                continue
             response = self.bus.wait_for_response(
                 Message(f'mycroft.{ser}.is_ready',
                         context={"source": "skills", "destination": ser}))
@@ -177,6 +183,16 @@ def handle_ready(self, message: Message):
             LOG.debug("Ready notification disabled in settings")
         self.enclosure.eyes_blink("b")
 
+    @intent_handler("are_you_ready.intent")
+    def handle_enable_notification(self, message: Message):
+        """
+        Handle a request to enable ready announcements
+        """
+        if self.is_device_ready():
+            self.speak_dialog("confirm_ready")
+        else:
+            self.speak_dialog("deny_ready")
+
     @intent_handler("enable_ready_notification.intent")
     def handle_enable_notification(self, message: Message):
         """

diff --git a/locale/en-us/dialog/confirm_ready.dialog b/locale/en-us/dialog/confirm_ready.dialog
@@ -0,0 +1,5 @@
+My system is fully ready.
+All services are up and running.
+My system is ready to go.
+Everything is up and operational.
+My system has finished booting and is ready.
diff --git a/locale/en-us/dialog/deny_ready.dialog b/locale/en-us/dialog/deny_ready.dialog
@@ -0,0 +1,5 @@
+My system is not fully ready yet.
+Some services are still starting up.
+My system is still booting, please wait.
+Not everything is ready yet.
+The system isn't fully operational yet, please give me some more time.
diff --git a/locale/en-us/intent/are_you_ready.intent b/locale/en-us/intent/are_you_ready.intent
@@ -0,0 +1,10 @@
+Is (your|the|Open Voice OS) system ready
+Did (you|all services|the system|Open Voice OS|the device) finish booting
+Are (you|all services) (ready|fully loaded|still loading|up and running)
+(Have you|Has the system) finished (starting|loading|start up|boot sequence)
+Is everything (ready|fully loaded|still loading|up and running)
+Have you finished (booting|loading|the boot sequence)
+Is (the system|Open Voice OS|the device) ready
+(Has|did) (the system|you|Open Voice OS) boot successfully
+Is the boot (process|sequence) complete
+Have (all services|you) started
diff --git a/scripts/bump_alpha.py b/scripts/bump_alpha.py
diff --git a/scripts/bump_build.py b/scripts/bump_build.py
diff --git a/scripts/bump_major.py b/scripts/bump_major.py
diff --git a/scripts/bump_minor.py b/scripts/bump_minor.py
diff --git a/scripts/remove_alpha.py b/scripts/remove_alpha.py
diff --git a/translations/en-us/dialogs.json b/translations/en-us/dialogs.json
@@ -5,7 +5,21 @@
     "/dialog/ready.dialog": [
         "I am ready!"
     ],
+    "/dialog/confirm_ready.dialog": [
+        "My system is fully ready.",
+        "All services are up and running.",
+        "My system is ready to go.",
+        "Everything is up and operational.",
+        "My system has finished booting and is ready."
+    ],
     "/dialog/confirm_speak_ready.dialog": [
         "Okay. I will tell you when I am ready after restarts."
+    ],
+    "/dialog/deny_ready.dialog": [
+        "My system is not fully ready yet.",
+        "Some services are still starting up.",
+        "My system is still booting, please wait.",
+        "Not everything is ready yet.",
+        "The system isn't fully operational yet, please give me some more time."
     ]
 }
diff --git a/translations/en-us/intents.json b/translations/en-us/intents.json
@@ -1,4 +1,16 @@
 {
+    "/intent/are_you_ready.intent": [
+        "Is (your|the|Open Voice OS) system ready",
+        "Did (you|all services|the system|Open Voice OS|the device) finish booting",
+        "Are (you|all services) (ready|fully loaded|still loading|up and running)",
+        "(Have you|Has the system) finished (starting|loading|start up|boot sequence)",
+        "Is everything (ready|fully loaded|still loading|up and running)",
+        "Have you finished (booting|loading|the boot sequence)",
+        "Is (the system|Open Voice OS|the device) ready",
+        "(Has|did) (the system|you|Open Voice OS) boot successfully",
+        "Is the boot (process|sequence) complete",
+        "Have (all services|you) started"
+    ],
     "/intent/disable_ready_notification.intent": [
         "(disable|turn off|deactivate) (ready|start|startup|start up|boot|load|readiness|started|booted|loaded) (sound|notification|speech|sounds|notifications)"
     ],