Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:method name #16

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix:method name #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ocp_pipeline/opm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1067,7 +1067,7 @@ def match_legacy(self, utterances: List[str], lang: str, message: Message = None

legacy base class at mycroft/skills/common_play_skill.py marked for removal in ovos-core 0.1.0
"""
return MycroftCPSLegacyPipeline(self.bus, self.config).match_high(utterances, lang, message)
return MycroftCPSLegacyPipeline(self.bus, self.config).match(utterances, lang, message)

Comment on lines +1070 to 1071
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Residual references to match_fallback found in test files need updating.

The match_fallback method is still referenced in the test suite. Please update all test cases to use match_low to ensure consistency and remove deprecated references.

  • tests/test_ocp.py:
    • test_match_fallback
    • test_match_fallback_with_invalid_input
🔗 Analysis chain

Verify the impact of renaming match_fallback to match_low.

The method match_fallback has been renamed to match_low. This change improves the naming convention to better reflect the method's purpose in the matching pipeline.

To ensure this change doesn't break any existing code, please run the following script:

Update the search command to use the correct flag for file type.

Please run the following corrected script to search for any remaining references to match_fallback:

Update the search command to target Python files using glob patterns.

Please run the following corrected script to search for any remaining references to match_fallback:

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any remaining references to 'match_fallback'
rg --type python 'match_fallback'

Length of output: 64

Script:

#!/bin/bash
# Search for any remaining references to 'match_fallback'
rg -t python 'match_fallback'

Length of output: 60

Script:

#!/bin/bash
# Search for any remaining references to 'match_fallback' in Python files
rg 'match_fallback' --glob '**/*.py'

Length of output: 517


class MycroftCPSLegacyPipeline(PipelineStageMatcher):
Expand Down
Loading