default to OCP pipeline + support for utils 0.0.38 #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JarbasAl
added
refactor
JarbasAl
force-pushed
the
JarbasAl-patch-1
branch
from
0931bdd to
7ed548b
Compare
JarbasAl
changed the title
JarbasAl
commented
Jun 2, 2024
| from ovos_config.version import VERSION_BUILD, VERSION_ALPHA, VERSION_MAJOR, VERSION_MINOR | ||
| if VERSION_BUILD > 13 or VERSION_MAJOR >= 1 or VERSION_MINOR >= 1: | ||
| return True | ||
| return VERSION_BUILD == 13 and VERSION_ALPHA >= 14 |
There was a problem hiding this comment.
for anyone reviewing this is the relevant change to account for OpenVoiceOS/ovos-core#491 and OpenVoiceOS/ovos-config#96
Merged
JarbasAl
added a commit
that referenced
this pull request
Sep 3, 2024
* refactor/utils_0.1.0 (#108) * refactor/utils_0.1.0 * opm imports * no create .desktop file * no create .desktop file * requirements * requirements --------- Co-authored-by: JarbasAi <[email protected]> * Increment Version to 0.0.7a1 * Update Changelog * refactor/dry_ocp_imports (#109) * refactor/dry_ocp_imports import Playlist and MediaEntry objects from utils 0.1.0 * tests * tests * fix/ocp_playlist allow initing Playlist object as a regular list --------- Co-authored-by: JarbasAi <[email protected]> * Increment Version to 0.0.7a2 * Update Changelog * feat/experimental_ocp_pipeline (#112) allow using Classic OCP with the new pipeline companion to OpenVoiceOS/ovos-core#456 * Increment Version to 0.0.7a3 * Update Changelog * fix/coexistence_with_pipeline (#115) * fix/coexistence_with_pipeline intents were being registered even if pipeline enabled, only the media matchers were taking into account the new flag this commit moves the check to init instead * port/SEI report event report plugins to ovos-core like ovos-media does to help in transition * fix stop * Increment Version to 0.0.7a4 * Update Changelog * fix/playlist handling (#116) * fix deprecation warnings * fix type checks * better log * support older ovos-utils * type checking fixes * typing * yeah * Increment Version to 0.0.7a5 * Update Changelog * fix/playlist_again (#117) * Increment Version to 0.0.7a6 * Update Changelog * default to OCP pipeline + support for utils 0.0.38 (#119) * remove dead code since OpenVoiceOS/ovos-core#491 and OpenVoiceOS/ovos-config#96 this is effectively dead code all NLP matching is dropped in this PR * rm dead code * drop old tests * Increment Version to 0.0.7a7 * Update Changelog * fix/native_sources (#120) * fix/native_sources allow usage with voice satellites, without triggering playback on master side similar to what classic audio service does, but with a decorator to make it more usable * handle message=None * fix backend check * kwarg * add helper property * message None * default val * missing kwarg * drop old classifier tests * drop old classifier tests * keep your crappy test * keep your crappy test * a relevant test now * Increment Version to 0.0.7a8 * Update Changelog * fix/play_from_gui (#121) * fix/play_from_gui when selecting entries from featured media PluginStream was not being recognized if audio restarts with GUI opening, playback would fail due to GUI sending malformed data, this commit also works around that issue * more fixes * more fixes * update tests * restore tst * keep old OCP bugs around 👍 * fixy fixes * Increment Version to 0.0.7a9 * Update Changelog * fix/playlist_handling (#122) * fix/playlist_handling fix position of "now playing" handling fix PluginStream to MediaEntry extraction fix Playlist of PluginStream * deprecate extract_stream * check bounds of idx * remove test for old ovos-audio version compat with utils 0.0.38 * fix tests * Increment Version to 0.0.7a10 * Update Changelog * Update README.md * logs/end_of_track (#124) make it easier to debug issues like #123 * Increment Version to 0.0.7a11 * Update Changelog * Increment Version to 0.0.7 * Update Changelog --------- Co-authored-by: NeonJarbas <[email protected]> Co-authored-by: JarbasAi <[email protected]> Co-authored-by: JarbasAl <[email protected]> Co-authored-by: JarbasAI <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds support for utils 0.0.38
since OpenVoiceOS/ovos-core#491 and OpenVoiceOS/ovos-config#96 this is effectively dead code, all NLP matching is dropped in this PR
EDIT: decided to keep dead code, as the whole repo is deprecated anyway