Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/playlist_again #117

Merged
merged 1 commit into from
May 28, 2024
Merged

fix/playlist_again #117

merged 1 commit into from
May 28, 2024

Conversation

JarbasAl
Copy link
Member

No description provided.

@JarbasAl JarbasAl added the bug Something isn't working label May 27, 2024
Copy link

@mikejgray mikejgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue I had with the new pipeline and the Plex skill, LGTM

@JarbasAl JarbasAl marked this pull request as ready for review May 28, 2024 01:07
@JarbasAl JarbasAl merged commit a74eab6 into dev May 28, 2024
4 checks passed
@JarbasAl JarbasAl deleted the fix/playlist_again branch May 28, 2024 01:07
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
JarbasAl added a commit that referenced this pull request Sep 3, 2024
* refactor/utils_0.1.0 (#108)

* refactor/utils_0.1.0

* opm imports

* no create .desktop file

* no create .desktop file

* requirements

* requirements

---------

Co-authored-by: JarbasAi <[email protected]>

* Increment Version to 0.0.7a1

* Update Changelog

* refactor/dry_ocp_imports (#109)

* refactor/dry_ocp_imports

import Playlist and MediaEntry objects from utils 0.1.0

* tests

* tests

* fix/ocp_playlist

allow initing Playlist object as a regular list

---------

Co-authored-by: JarbasAi <[email protected]>

* Increment Version to 0.0.7a2

* Update Changelog

* feat/experimental_ocp_pipeline (#112)

allow using Classic OCP with the new pipeline

companion to OpenVoiceOS/ovos-core#456

* Increment Version to 0.0.7a3

* Update Changelog

* fix/coexistence_with_pipeline (#115)

* fix/coexistence_with_pipeline

intents were being registered even if pipeline enabled, only the media matchers were taking into account the new flag

this commit moves the check to init instead

* port/SEI report event

report plugins to ovos-core like ovos-media does to help in transition

* fix stop

* Increment Version to 0.0.7a4

* Update Changelog

* fix/playlist handling (#116)

* fix deprecation warnings

* fix type checks

* better log

* support older ovos-utils

* type checking fixes

* typing

* yeah

* Increment Version to 0.0.7a5

* Update Changelog

* fix/playlist_again (#117)

* Increment Version to 0.0.7a6

* Update Changelog

* default to OCP pipeline + support for utils 0.0.38 (#119)

* remove dead code

since OpenVoiceOS/ovos-core#491 and OpenVoiceOS/ovos-config#96 this is effectively dead code

all NLP matching is dropped in this PR

* rm dead code

* drop old tests

* Increment Version to 0.0.7a7

* Update Changelog

* fix/native_sources (#120)

* fix/native_sources

allow usage with voice satellites, without triggering playback on master side

similar to what classic audio service does, but with a decorator to make it more usable

* handle message=None

* fix backend check

* kwarg

* add helper property

* message None

* default val

* missing kwarg

* drop old classifier tests

* drop old classifier tests

* keep your crappy test

* keep your crappy test

* a relevant test now

* Increment Version to 0.0.7a8

* Update Changelog

* fix/play_from_gui (#121)

* fix/play_from_gui

when selecting entries from featured media PluginStream was not being recognized

if audio restarts with GUI opening, playback would fail due to GUI sending malformed data, this commit also works around that issue

* more fixes

* more fixes

* update tests

* restore tst

* keep old OCP bugs around 👍

* fixy fixes

* Increment Version to 0.0.7a9

* Update Changelog

* fix/playlist_handling (#122)

* fix/playlist_handling

fix position of "now playing" handling

fix PluginStream to MediaEntry extraction

fix Playlist of PluginStream

* deprecate extract_stream

* check bounds of idx

* remove test for old ovos-audio version

compat with utils 0.0.38

* fix tests

* Increment Version to 0.0.7a10

* Update Changelog

* Update README.md

* logs/end_of_track (#124)

make it easier to debug issues like  #123

* Increment Version to 0.0.7a11

* Update Changelog

* Increment Version to 0.0.7

* Update Changelog

---------

Co-authored-by: NeonJarbas <[email protected]>
Co-authored-by: JarbasAi <[email protected]>
Co-authored-by: JarbasAl <[email protected]>
Co-authored-by: JarbasAI <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants