Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to use host paths in containers in addition to http URLs #25

Merged
merged 12 commits into from
Sep 29, 2023
Merged

Add option to use host paths in containers in addition to http URLs #25

merged 12 commits into from
Sep 29, 2023

Conversation

NeonDaniel
Copy link
Member

Add support for mapping GUI resources to a host path for improved container support
Relates to #19
Relates to #24

JarbasAl
JarbasAl reviewed Aug 2, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@JarbasAl JarbasAl mentioned this pull request Aug 7, 2023
Closed
@NeonDaniel NeonDaniel marked this pull request as ready for review September 28, 2023 01:02
@NeonDaniel NeonDaniel marked this pull request as draft September 28, 2023 01:02
@NeonDaniel NeonDaniel force-pushed the FEAT_HostPathResources branch from 093cbc2 to e02441f Compare September 28, 2023 01:05
@NeonDaniel
Troubleshoot test failure
c27ca3f 
Revert refactored config change to match existing parameter name
@codecov
Copy link

codecov bot commented Sep 28, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (dev@4b012ba). Click here to learn what that means.

Additional details and impacted files 
@@          Coverage Diff           @@
##             dev      #25   +/-   ##
======================================
  Coverage       ?   52.92%           
======================================
  Files          ?       11           
  Lines          ?     1007           
  Branches       ?        0           
======================================
  Hits           ?      533           
  Misses         ?      474           
  Partials       ?        0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NeonDaniel NeonDaniel requested a review from JarbasAl September 28, 2023 02:15
@NeonDaniel NeonDaniel marked this pull request as ready for review September 28, 2023 18:38
@goldyfruit
Copy link
Member 

2023-09-28 15:46:36.858 - gui - ovos_gui.namespace:handle_gui_pages_available:516 - DEBUG - No GUI file server running or host path configured
2023-09-28 15:46:36.863 - gui - ovos_gui.namespace:handle_gui_pages_available:516 - DEBUG - No GUI file server running or host path configured
2023-09-28 15:46:37.228 - gui - ovos_gui.namespace:handle_gui_pages_available:516 - DEBUG - No GUI file server running or host path configured
2023-09-28 15:46:37.237 - gui - ovos_gui.namespace:handle_gui_pages_available:516 - DEBUG - No GUI file server running or host path configured
2023-09-28 15:46:38.157 - gui - ovos_gui.namespace:handle_gui_pages_available:516 - DEBUG - No GUI file server running or host path configured
2023-09-28 15:46:38.161 - gui - ovos_gui.namespace:handle_gui_pages_available:516 - DEBUG - No GUI file server running or host path configured
2023-09-28 15:46:38.199 - gui - ovos_gui.namespace:handle_gui_pages_available:516 - DEBUG - No GUI file server running or host path configured
2023-09-28 15:46:38.203 - gui - ovos_gui.namespace:handle_gui_pages_available:516 - DEBUG - No GUI file server running or host path configured
2023-09-28 15:46:38.467 - gui - ovos_gui.namespace:handle_gui_pages_available:516 - DEBUG - No GUI file server running or host path configured
2023-09-28 15:46:38.472 - gui - ovos_gui.namespace:handle_gui_pages_available:516 - DEBUG - No GUI file server running or host path configured
2023-09-28 15:46:43.963 - gui - ovos_config.models:load_local:112 - DEBUG - Configuration /home/ovos/.config/mycroft/web_cache.json loaded
2023-09-28 15:47:22.957 - gui - ovos_config.models:load_local:112 - DEBUG - Configuration /home/ovos/.config/mycroft/web_cache.json loaded
2023-09-28 15:47:26.018 - gui - ovos_gui.namespace:_remove_namespace:825 - DEBUG - Removing namespace skill-ovos-weather.openvoiceos
2023-09-28 15:47:26.026 - gui - ovos_plugin_manager.templates.gui:handle_remove_namespace:55 - INFO - Got Clear Namespace Event In Skill
2023-09-28 15:47:26.030 - gui - ovos_gui.namespace:_remove_namespace:825 - DEBUG - Removing namespace skill-ovos-weather.openvoiceos
2023-09-28 15:47:26.071 - gui - ovos_plugin_manager.templates.gui:handle_remove_namespace:55 - INFO - Got Clear Namespace Event In Skill
2023-09-28 15:47:26.074 - gui - ovos_gui.namespace:handle_gui_pages_available:516 - DEBUG - No GUI file server running or host path configured
2023-09-28 15:47:26.075 - gui - ovos_gui.namespace:handle_gui_pages_available:516 - DEBUG - No GUI file server running or host path configured
2023-09-28 15:47:26.077 - gui - ovos_gui.namespace:_remove_namespace:825 - DEBUG - Removing namespace skill-ovos-wikipedia.openvoiceos
2023-09-28 15:47:26.078 - gui - ovos_plugin_manager.templates.gui:handle_remove_namespace:55 - INFO - Got Clear Namespace Event In Skill
2023-09-28 15:47:26.089 - gui - ovos_gui.namespace:_remove_namespace:825 - DEBUG - Removing namespace skill-ovos-wikipedia.openvoiceos
2023-09-28 15:47:26.129 - gui - ovos_gui.namespace:handle_gui_pages_available:516 - DEBUG - No GUI file server running or host path configured
2023-09-28 15:47:26.129 - gui - ovos_gui.namespace:handle_gui_pages_available:516 - DEBUG - No GUI file server running or host path configured
2023-09-28 15:47:26.131 - gui - ovos_plugin_manager.templates.gui:handle_remove_namespace:55 - INFO - Got Clear Namespace Event In Skill
2023-09-28 15:47:26.184 - gui - ovos_gui.namespace:_remove_namespace:825 - DEBUG - Removing namespace skill-ovos-fallback-unknown.openvoiceos
2023-09-28 15:47:26.188 - gui - ovos_plugin_manager.templates.gui:handle_remove_namespace:55 - INFO - Got Clear Namespace Event In Skill
2023-09-28 15:47:26.354 - gui - ovos_gui.namespace:_remove_namespace:825 - DEBUG - Removing namespace skill-ovos-hello-world.openvoiceos
2023-09-28 15:47:26.355 - gui - ovos_plugin_manager.templates.gui:handle_remove_namespace:55 - INFO - Got Clear Namespace Event In Skill
2023-09-28 15:47:26.403 - gui - ovos_plugin_manager.templates.gui:handle_remove_namespace:55 - INFO - Got Clear Namespace Event In Skill
2023-09-28 15:47:26.404 - gui - ovos_gui.namespace:_remove_namespace:825 - DEBUG - Removing namespace ovos-skill-personal.OpenVoiceOS
2023-09-28 15:47:26.448 - gui - ovos_gui.namespace:_remove_namespace:825 - DEBUG - Removing namespace skill-ovos-tunein.openvoiceos
2023-09-28 15:47:26.449 - gui - ovos_plugin_manager.templates.gui:handle_remove_namespace:55 - INFO - Got Clear Namespace Event In Skill
2023-09-28 15:47:26.453 - gui - ovos_gui.namespace:handle_gui_pages_available:516 - DEBUG - No GUI file server running or host path configured
2023-09-28 15:47:26.454 - gui - ovos_gui.namespace:handle_gui_pages_available:516 - DEBUG - No GUI file server running or host path configured
2023-09-28 15:47:26.496 - gui - ovos_gui.namespace:_remove_namespace:825 - DEBUG - Removing namespace skill-ovos-icanhazdadjokes.openvoiceos
2023-09-28 15:47:26.499 - gui - ovos_plugin_manager.templates.gui:handle_remove_namespace:55 - INFO - Got Clear Namespace Event In Skill
2023-09-28 15:47:26.504 - gui - ovos_gui.namespace:handle_gui_pages_available:516 - DEBUG - No GUI file server running or host path configured
2023-09-28 15:47:26.547 - gui - ovos_gui.namespace:_remove_namespace:825 - DEBUG - Removing namespace skill-ovos-volume.openvoiceos
2023-09-28 15:47:26.547 - gui - ovos_gui.namespace:handle_gui_pages_available:516 - DEBUG - No GUI file server running or host path configured
2023-09-28 15:47:26.548 - gui - ovos_plugin_manager.templates.gui:handle_remove_namespace:55 - INFO - Got Clear Namespace Event In Skill
2023-09-28 15:47:26.703 - gui - ovos_gui.namespace:_remove_namespace:825 - DEBUG - Removing namespace skill-ovos-date-time.openvoiceos
2023-09-28 15:47:26.707 - gui - ovos_plugin_manager.templates.gui:handle_remove_namespace:55 - INFO - Got Clear Namespace Event In Skill
2023-09-28 15:47:26.753 - gui - ovos_gui.namespace:handle_gui_pages_available:516 - DEBUG - No GUI file server running or host path configured
2023-09-28 15:47:26.753 - gui - ovos_gui.namespace:handle_gui_pages_available:516 - DEBUG - No GUI file server running or host path configured
2023-09-28 15:47:26.981 - gui - ovos_gui.namespace:_remove_namespace:825 - DEBUG - Removing namespace skill-ovos-wolfie.openvoiceos
2023-09-28 15:47:26.985 - gui - ovos_plugin_manager.templates.gui:handle_remove_namespace:55 - INFO - Got Clear Namespace Event In Skill
2023-09-28 15:47:27.034 - gui - ovos_gui.namespace:handle_gui_pages_available:516 - DEBUG - No GUI file server running or host path configured
2023-09-28 15:47:27.037 - gui - ovos_gui.namespace:handle_gui_pages_available:516 - DEBUG - No GUI file server running or host path configured
2023-09-28 15:47:27.037 - gui - ovos_gui.namespace:_remove_namespace:825 - DEBUG - Removing namespace skill-ovos-stop.openvoiceos
2023-09-28 15:47:27.038 - gui - ovos_plugin_manager.templates.gui:handle_remove_namespace:55 - INFO - Got Clear Namespace Event In Skill
2023-09-28 15:47:27.088 - gui - ovos_gui.namespace:_remove_namespace:825 - DEBUG - Removing namespace skill-ovos-weather.openvoiceos
2023-09-28 15:47:27.088 - gui - ovos_gui.namespace:_remove_namespace:825 - DEBUG - Removing namespace skill-ovos-weather.openvoiceos
2023-09-28 15:47:27.089 - gui - ovos_gui.namespace:_remove_namespace:825 - DEBUG - Removing namespace skill-ovos-wikipedia.openvoiceos
2023-09-28 15:47:27.090 - gui - ovos_gui.namespace:_remove_namespace:825 - DEBUG - Removing namespace skill-ovos-wikipedia.openvoiceos
2023-09-28 15:47:27.095 - gui - ovos_gui.namespace:_remove_namespace:825 - DEBUG - Removing namespace skill-ovos-fallback-unknown.openvoiceos
2023-09-28 15:47:27.099 - gui - ovos_gui.namespace:_remove_namespace:825 - DEBUG - Removing namespace skill-ovos-hello-world.openvoiceos
2023-09-28 15:47:27.102 - gui - ovos_gui.namespace:_remove_namespace:825 - DEBUG - Removing namespace ovos-skill-personal.OpenVoiceOS
2023-09-28 15:47:27.106 - gui - ovos_gui.namespace:_remove_namespace:825 - DEBUG - Removing namespace skill-ovos-tunein.openvoiceos
2023-09-28 15:47:27.109 - gui - ovos_gui.namespace:_remove_namespace:825 - DEBUG - Removing namespace skill-ovos-icanhazdadjokes.openvoiceos
2023-09-28 15:47:27.115 - gui - ovos_gui.namespace:_remove_namespace:825 - DEBUG - Removing namespace skill-ovos-volume.openvoiceos
2023-09-28 15:47:27.118 - gui - ovos_gui.namespace:_remove_namespace:825 - DEBUG - Removing namespace skill-ovos-date-time.openvoiceos
2023-09-28 15:47:27.122 - gui - ovos_gui.namespace:_remove_namespace:825 - DEBUG - Removing namespace skill-ovos-wolfie.openvoiceos
2023-09-28 15:47:27.128 - gui - ovos_gui.namespace:_remove_namespace:825 - DEBUG - Removing namespace skill-ovos-stop.openvoiceos
2023-09-28 15:47:28.101 - gui - ovos_gui.namespace:handle_gui_pages_available:516 - DEBUG - No GUI file server running or host path configured
2023-09-28 15:47:28.105 - gui - ovos_gui.namespace:handle_gui_pages_available:516 - DEBUG - No GUI file server running or host path configured

@goldyfruit
Copy link
Member

All good for me 👍

@JarbasAl JarbasAl merged commit ac81a30 into dev Sep 29, 2023
9 checks passed
@JarbasAl JarbasAl deleted the FEAT_HostPathResources branch September 29, 2023 01:59
@JarbasAl JarbasAl added the enhancement New feature or request label Sep 29, 2023
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldyfruit goldyfruit goldyfruit approved these changes

@JarbasAl JarbasAl Awaiting requested review from JarbasAl

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NeonDaniel @goldyfruit @JarbasAl