Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wallpaper rotation to handle changes from GUI #25

Merged
merged 7 commits into from
Jun 13, 2024
Merged

Update wallpaper rotation to handle changes from GUI #25

merged 7 commits into from
Jun 13, 2024

Conversation

NeonDaniel
Copy link
Member

@NeonDaniel NeonDaniel commented Jun 12, 2024 •
edited
Loading

Closes #27

Validated functionality on mark2 running Neon

@JarbasAl
Copy link
Member

JarbasAl commented Jun 12, 2024 •
edited
Loading

EDITED:

as discussed in the other issue i think this is the wrong fix, the problem is in the QML not python

currently it goes QML <-> ovos-gui websocket <-> ovos-bus <-> companion plugin <-> wallpaper manager plugin

i'm suggesting QML <-> ovos-bus <-> wallpaper plugin , like here

@JarbasAl JarbasAl added the bug Something isn't working label Jun 12, 2024
@NeonDaniel NeonDaniel mentioned this pull request Jun 12, 2024
Merged
@NeonDaniel NeonDaniel marked this pull request as ready for review June 12, 2024 21:07
@NeonDaniel NeonDaniel merged commit 9867c0c into dev Jun 13, 2024
6 checks passed
@NeonDaniel NeonDaniel deleted the FIX_WallpaperRotation branch June 13, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JarbasAl JarbasAl JarbasAl approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Wallpaper(s) are not being rotated through
2 participants
@NeonDaniel @JarbasAl