Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate:upload of ww/stt #159

Merged
merged 2 commits into from
Nov 19, 2024
Merged

deprecate:upload of ww/stt #159

merged 2 commits into from
Nov 19, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Nov 18, 2024

if desired wake-word/STT upload can be added back via a audio transformer plugin

Summary by CodeRabbit

  • New Features

    • Simplified audio handling logic for hotword detection, focusing on local processing without backend uploads.
  • Bug Fixes

    • Removed redundant error handling related to hotword audio uploads, enhancing overall service stability.

@JarbasAl JarbasAl requested a review from NeonDaniel November 18, 2024 18:52
Copy link
Contributor

coderabbitai bot commented Nov 18, 2024

Walkthrough

The pull request introduces significant changes to the OVOSDinkumVoiceService class in the ovos_dinkum_listener/service.py file. The _upload_hotword and _upload_stt methods have been completely removed, eliminating the functionality for uploading wake word and speech-to-text audio data to a backend service. The _hotword_audio and _stt_audio methods have been updated to remove any logic related to these uploads, indicating a shift towards local audio processing without backend interactions, thereby reducing complexity and external dependencies.

Changes

File Path Change Summary
ovos_dinkum_listener/service.py - Removed methods: _upload_hotword(self, wav_data, metadata) and _upload_stt(self, wav_data, metadata)
- Simplified _hotword_audio and _stt_audio methods by removing upload checks and associated logic.

Possibly related PRs

  • fix:handle empty string transcriptions #150: The changes in this PR involve modifications to the _stt_text method in the OVOSDinkumVoiceService class, which is closely related to the audio processing logic that has been simplified in the main PR by removing upload methods.
  • fix:add hotwords kwarg #154: This PR enhances the OVOSDinkumVoiceService class by adding a hotwords keyword argument and improving error handling related to microphone input, which aligns with the overall focus on refining audio handling in the main PR.

Poem

🐰 In the quiet of the night,
Hotwords whisper, taking flight.
No more uploads, just local cheer,
Our audio's safe, no backend near.
Simplified paths, we hop along,
In the world of sound, we sing our song! 🎶

Warning

Rate limit exceeded

@JarbasAl has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 3 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 82a9a7b and 2e4779b.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 82a9a7b and 2e4779b.

📒 Files selected for processing (1)
  • ovos_dinkum_listener/service.py (0 hunks)
💤 Files with no reviewable changes (1)
  • ovos_dinkum_listener/service.py

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@JarbasAl JarbasAl changed the title deprecate:backend client deprecate:upload of ww/stt Nov 19, 2024
@JarbasAl JarbasAl merged commit 87e59c3 into dev Nov 19, 2024
12 checks passed
@JarbasAl JarbasAl deleted the deprecate/backend_client branch November 19, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant