Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import basque translations #615

Merged
merged 2 commits into from
Dec 2, 2024
Merged

import basque translations #615

merged 2 commits into from
Dec 2, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Dec 2, 2024

Summary by CodeRabbit

  • New Features

    • Introduced new phrases in Basque for stopping actions, enhancing command recognition.
    • Added a new JSON file defining intent categories for stopping actions.
  • Bug Fixes

    • Cleaned up unused lines in Italian intent files, improving clarity and relevance.
  • Chores

    • Updated the translation synchronization script for better handling of translation files.

Copy link

coderabbitai bot commented Dec 2, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces new phrases in the Basque language for the global_stop.intent and stop.intent files, enhancing command recognition for stopping actions. It also includes a cleanup of unused lines in the Italian versions of these intents. Additionally, a new JSON file intents.json is created to define the intents for both stopping and global stopping actions in Basque. The script sync_translations.py is modified to improve the handling of translation files and ensure better data quality.

Changes

File Path Change Summary
ovos_core/intent_services/locale/eu/global_stop.intent Added multiple new phrases in Basque related to stopping actions.
`ovos_core/intent_services/locale/eu/stop.intent Added multiple new phrases in Basque related to stopping actions.
ovos_core/intent_services/locale/it-it/global_stop.intent Removed unused lines, retaining only relevant phrases for stopping actions in Italian.
`ovos_core/intent_services/locale/it-it/stop.intent Removed unused lines, retaining only relevant phrases for stopping actions in Italian.
scripts/sync_translations.py Enhanced filtering logic for translation samples and improved file writing process.
translations/eu/intents.json Created new JSON file defining stop.intent and global_stop.intent with phrases in Basque.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant System

    User->>System: "Eten uneko ekintza"
    System->>User: "Stopping the current action"
    
    User->>System: "Amaitu jarduera guztiak"
    System->>User: "Finishing all activities"
Loading

🐰 "In the land of phrases, we hop and play,
New commands in Basque brighten the day!
From stopping to halting, we now can say,
'Eten uneko ekintza'—let's pause and stay!
With a skip and a jump, our words are in sway,
Hooray for the changes, hip-hip-hooray!" 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9f73c4f and 455327b.

📒 Files selected for processing (6)
  • ovos_core/intent_services/locale/eu/global_stop.intent (1 hunks)
  • ovos_core/intent_services/locale/eu/stop.intent (1 hunks)
  • ovos_core/intent_services/locale/it-it/global_stop.intent (0 hunks)
  • ovos_core/intent_services/locale/it-it/stop.intent (0 hunks)
  • scripts/sync_translations.py (1 hunks)
  • translations/eu/intents.json (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@JarbasAl JarbasAl merged commit 05bdbfd into dev Dec 2, 2024
5 of 6 checks passed
@JarbasAl JarbasAl deleted the import_eu branch December 2, 2024 16:37
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.13%. Comparing base (23f0bab) to head (455327b).
Report is 110 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #615      +/-   ##
==========================================
- Coverage   75.33%   73.13%   -2.21%     
==========================================
  Files          15       15              
  Lines        3094     1526    -1568     
==========================================
- Hits         2331     1116    -1215     
+ Misses        763      410     -353     
Flag Coverage Δ
unittests 49.34% <ø> (-26.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant