fix: drop lingua_franca

[JarbasAl]

closes #592

Summary by CodeRabbit

Release Notes

• New Features

  • Introduced new dependencies for enhanced functionality, including ovos-number-parser and ovos-date-parser.

• Bug Fixes

  • Streamlined error handling in the intent and converse services, improving reliability in language setup processes.

• Chores

  • Updated dependency requirements to include several new packages and removed deprecated ones for better project maintenance.

[coderabbitai]

Warning

Rate limit exceeded

@JarbasAl has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 30 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between f530fef and ab8768a.

Walkthrough

The pull request introduces significant changes primarily focused on error handling and code cleanup within the IntentService and ConverseService classes. It removes several deprecated methods and simplifies locale setup by eliminating try-except blocks, which previously managed exceptions during language configuration. Additionally, new dependencies are added to the requirements files, including ovos-number-parser and ovos-date-parser, while also removing the deprecated ovos-lingua-franca. These modifications aim to enhance maintainability and streamline functionality.

Changes

File Path	Change Summary
ovos_core/intent_services/__init__.py	Removed try-except block in handle_utterance, deleted deprecated methods related to intent handling.
ovos_core/intent_services/converse_service.py	Removed try-except block in reset_converse, maintained existing skill activation logic.
requirements/extra-deprecated.txt	Added dependency ovos-lingua-franca>=0.4.7,<1.0.0, noted conflict with ovos-listener.
requirements/plugins.txt	Added dependencies: ovos-number-parser>=0.0.1,<1.0.0, ovos-date-parser>=0.0.1,<1.0.0.
requirements/requirements.txt	Added dependencies: ovos-utils>=0.3.5,<1.0.0, ovos_bus_client>=0.1.4,<2.0.0, ovos-plugin-manager>=0.5.6,<1.0.0, ovos-config>=0.0.13,<1.0.0, ovos-utterance-normalizer>=0.0.1,<1.0.0; removed ovos-lingua-franca.

Assessment against linked issues

Objective	Addressed	Explanation
Deprecate lingua-franca (#[592])	✅
Introduce smaller packages for language handling (#[592])	✅

Possibly related PRs

• feat/pipeline_plugins_opm #527: Changes in ovos_core/intent_services/__init__.py and ovos_core/intent_services/converse_service.py focus on removing try-except blocks related to locale setup.
• improve_typing #528: Modifications in ovos_core/intent_services/__init__.py and adapt_service.py reflect changes in intent processing logic, relevant to the main PR.
• fix:log_spam #566: Updates in ovos_core/intent_services/__init__.py regarding deprecation logging are closely related to the changes in error handling in the main PR.
• fix:standardize_lang #568: Focus on standardizing language handling across services aligns with the changes made in locale management.

Suggested labels

refactor, dependencies

Suggested reviewers

• goldyfruit
• j1nx
• builderjer

Poem

In the burrow deep, where the code does flow,
A rabbit hops in, with changes to show.
With locales set right, and methods set free,
We tidy the paths, for all to see.
Dependencies added, old ones now gone,
A cleaner, bright future, let’s hop on and yawn! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.11%. Comparing base (23f0bab) to head (ab8768a).
Report is 64 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #593      +/-   ##
==========================================
- Coverage   75.33%   73.11%   -2.22%     
==========================================
  Files          15       15              
  Lines        3094     1529    -1565     
==========================================
- Hits         2331     1118    -1213     
+ Misses        763      411     -352     

Flag	Coverage Δ
end2end	56.50% <ø> (?)
unittests	49.37% <ø> (-25.97%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

requirements/requirements.txt (1)

Line range hint 1-18: Missing specialized parser dependencies

The PR objectives mention replacing lingua-franca with specialized packages, but the following dependencies are missing from requirements.txt:

• ovos-number-parser
• ovos-date-parser
• ovos-lang-parser
• ovos-color-parser
• ovos-solver-YesNo-plugin

These packages should be added to maintain the functionality previously provided by lingua-franca.

Would you like me to provide the dependency specifications for these packages or create a GitHub issue to track this?

requirements/extra-deprecated.txt (1)

15-15: Address dependency conflict blocking upgrades

The comment indicates that ovos-listener is blocking the upgrade to ovos-bus-client 1.0.0. This dependency conflict should be resolved to ensure smooth package management and system stability.

Consider:

1. Investigating if the newer versions of ovos-listener resolve this conflict
2. Evaluating if ovos-listener can be updated to be compatible with ovos-bus-client 1.0.0
3. Documenting the resolution plan in the related issue tracker

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 8c7b27e and f530fef.

📒 Files selected for processing (5)

• ovos_core/intent_services/__init__.py (0 hunks)
• ovos_core/intent_services/converse_service.py (0 hunks)
• requirements/extra-deprecated.txt (1 hunks)
• requirements/plugins.txt (1 hunks)
• requirements/requirements.txt (1 hunks)

💤 Files with no reviewable changes (2)

• ovos_core/intent_services/init.py
• ovos_core/intent_services/converse_service.py

✅ Files skipped from review due to trivial changes (1)

• requirements/plugins.txt

🔇 Additional comments (1)

requirements/requirements.txt (1)

Line range hint 1-18: Verify complete removal of lingua-franca dependency

Let's ensure all references to lingua-franca have been properly removed from the codebase.