-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update watchdog requirement from <3.0,>=2.1 to >=2.1,<7.0 in /requirements #582
base: dev
Are you sure you want to change the base?
Update watchdog requirement from <3.0,>=2.1 to >=2.1,<7.0 in /requirements #582
Conversation
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #582 +/- ##
==========================================
- Coverage 75.33% 74.82% -0.52%
==========================================
Files 15 15
Lines 3094 1537 -1557
==========================================
- Hits 2331 1150 -1181
+ Misses 763 387 -376
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
941adf8
to
088810b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tentative approval pending review from Neon. watchdog 5.0.0 had a number of breaking changes and any packages relying on ovos-core to keep that pinned could see unpleasant results: https://github.com/gorakhargosh/watchdog/blob/master/changelog.rst#500
3.0, 4.0, and 6.0 look pretty safe though.
Updates the requirements on [watchdog](https://github.com/gorakhargosh/watchdog) to permit the latest version. - [Release notes](https://github.com/gorakhargosh/watchdog/releases) - [Changelog](https://github.com/gorakhargosh/watchdog/blob/master/changelog.rst) - [Commits](gorakhargosh/watchdog@v2.1.0...v6.0.0) --- updated-dependencies: - dependency-name: watchdog dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
088810b
to
69b56ef
Compare
Updates the requirements on watchdog to permit the latest version.
Release notes
Sourced from watchdog's releases.
Changelog
Sourced from watchdog's changelog.
... (truncated)
Commits
76c091d
Version 6.0.058386d8
Fixes, and clean-up (#1084)db698a5
fix: reading inotify file descriptor after closing it. (#1081)73d5612
[docs] Add typing info to quick start (#1082)d774fec
docs: Update README Badges (#1083)6b74737
docs: funding3d1b888
[inotify] Use ofselect.poll()
instead of deprecatedselect.select()
(#1078)6a4f1cf
Bump the versionad6df50
Version 5.0.359650f8
fix: polish #1070You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)