Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update watchdog requirement from <3.0,>=2.1 to >=2.1,<7.0 in /requirements #582

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Nov 2, 2024

Updates the requirements on watchdog to permit the latest version.

Release notes

Sourced from watchdog's releases.

6.0.0

Breaking Changes

  • [inotify] Use of select.poll() instead of deprecated select.select(), if available. (#1078)
  • [utils] Removed the unused echo_class() function from the echo module.
  • [utils] Removed the unused echo_instancemethod() function from the echo module.
  • [utils] Removed the unused echo_module() function from the echo module.
  • [utils] Removed the unused is_class_private_name() function from the echo module.
  • [utils] Removed the unused is_classmethod() function from the echo module.
  • [utils] Removed the unused ic_method(met() function from the echo module.
  • [utils] Removed the unused method_name() function from the echo module.
  • [utils] Removed the unused name() function from the echo module.
  • [watchmedo] Removed the --trace CLI argument from the watchmedo log command, useless since events are logged by default at the LoggerTrick class level.

Other CHanges

  • Pin test dependecies.
  • [docs] Add typing info to quick start. (#1082)
  • [inotify] Fix reading inotify file descriptor after closing it. (#1081)
  • [utils] The stop_signal keyword-argument type of the AutoRestartTrick class can now be either a signal.Signals or an int.
  • [utils] Added the __repr__() method to the Trick class.
  • [watchmedo] Fixed Mypy issues.
  • [watchmedo] Added the __repr__() method to the HelpFormatter class.
  • [windows] Fixed Mypy issues.

💟 Thanks to our beloved contributors: @​g-pichler, @​ethan-vanderheijden, @​nhairs, @​BoboTiG

Changelog

Sourced from watchdog's changelog.

6.0.0


2024-11-01 • `full history <https://github.com/gorakhargosh/watchdog/compare/v5.0.3...v6.0.0>`__
  • Pin test dependecies.
  • [docs] Add typing info to quick start. ([#1082](https://github.com/gorakhargosh/watchdog/issues/1082) &lt;https://github.com/gorakhargosh/watchdog/pull/1082&gt;__)
  • [inotify] Use of select.poll() instead of deprecated select.select(), if available. ([#1078](https://github.com/gorakhargosh/watchdog/issues/1078) &lt;https://github.com/gorakhargosh/watchdog/pull/1078&gt;__)
  • [inotify] Fix reading inotify file descriptor after closing it. ([#1081](https://github.com/gorakhargosh/watchdog/issues/1081) &lt;https://github.com/gorakhargosh/watchdog/pull/1081&gt;__)
  • [utils] The stop_signal keyword-argument type of the AutoRestartTrick class can now be either a signal.Signals or an int.
  • [utils] Added the __repr__() method to the Trick class.
  • [utils] Removed the unused echo_class() function from the echo module.
  • [utils] Removed the unused echo_instancemethod() function from the echo module.
  • [utils] Removed the unused echo_module() function from the echo module.
  • [utils] Removed the unused is_class_private_name() function from the echo module.
  • [utils] Removed the unused is_classmethod() function from the echo module.
  • [utils] Removed the unused ic_method(met() function from the echo module.
  • [utils] Removed the unused method_name() function from the echo module.
  • [utils] Removed the unused name() function from the echo module.
  • [watchmedo] Fixed Mypy issues.
  • [watchmedo] Added the __repr__() method to the HelpFormatter class.
  • [watchmedo] Removed the --trace CLI argument from the watchmedo log command, useless since events are logged by default at the LoggerTrick class level.
  • [windows] Fixed Mypy issues.
  • Thanks to our beloved contributors: @​BoboTiG, @​g-pichler, @​ethan-vanderheijden, @​nhairs

5.0.3

2024-09-27 • full history <https://github.com/gorakhargosh/watchdog/compare/v5.0.2...v5.0.3>__

  • [inotify] Improve cleaning up Inotify threads, and add eventlet test cases ([#1070](https://github.com/gorakhargosh/watchdog/issues/1070) <https://github.com/gorakhargosh/watchdog/pull/1070>__)
  • Thanks to our beloved contributors: @​BoboTiG, @​ethan-vanderheijden

5.0.2


2024-09-03 • `full history <https://github.com/gorakhargosh/watchdog/compare/v5.0.1...v5.0.2>`__
  • Enable OS specific Mypy checks ([#1064](https://github.com/gorakhargosh/watchdog/issues/1064) &lt;https://github.com/gorakhargosh/watchdog/pull/1064&gt;__)
  • [watchmedo] Fix tricks argument type of schedule_tricks() ([#1063](https://github.com/gorakhargosh/watchdog/issues/1063) &lt;https://github.com/gorakhargosh/watchdog/pull/1063&gt;__)
  • Thanks to our beloved contributors: @​gnought, @​BoboTiG

5.0.1

2024-09-02 • full history <https://github.com/gorakhargosh/watchdog/compare/v5.0.0...v5.0.1>__

  • [kqueue] Fix TypeError: kqueue.control() only accepts positional parameters ([#1062](https://github.com/gorakhargosh/watchdog/issues/1062) <https://github.com/gorakhargosh/watchdog/pull/1062>__)
  • Thanks to our beloved contributors: @​apoirier, @​BoboTiG

... (truncated)

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 2, 2024
Copy link

coderabbitai bot commented Nov 2, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.82%. Comparing base (23f0bab) to head (941adf8).
Report is 47 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #582      +/-   ##
==========================================
- Coverage   75.33%   74.82%   -0.52%     
==========================================
  Files          15       15              
  Lines        3094     1537    -1557     
==========================================
- Hits         2331     1150    -1181     
+ Misses        763      387     -376     
Flag Coverage Δ
end2end 56.34% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dependabot dependabot bot force-pushed the dependabot/pip/requirements/watchdog-gte-2.1-and-lt-7.0 branch from 941adf8 to 088810b Compare November 12, 2024 04:25
@JarbasAl JarbasAl requested review from NeonDaniel and a team November 12, 2024 04:37
Copy link

@mikejgray mikejgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentative approval pending review from Neon. watchdog 5.0.0 had a number of breaking changes and any packages relying on ovos-core to keep that pinned could see unpleasant results: https://github.com/gorakhargosh/watchdog/blob/master/changelog.rst#500

3.0, 4.0, and 6.0 look pretty safe though.

Updates the requirements on [watchdog](https://github.com/gorakhargosh/watchdog) to permit the latest version.
- [Release notes](https://github.com/gorakhargosh/watchdog/releases)
- [Changelog](https://github.com/gorakhargosh/watchdog/blob/master/changelog.rst)
- [Commits](gorakhargosh/watchdog@v2.1.0...v6.0.0)

---
updated-dependencies:
- dependency-name: watchdog
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pip/requirements/watchdog-gte-2.1-and-lt-7.0 branch from 088810b to 69b56ef Compare November 19, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant