Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/mycroft_compat #485

Merged
merged 2 commits into from
May 28, 2024
Merged

fix/mycroft_compat #485

merged 2 commits into from
May 28, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented May 28, 2024

partially solves #420

if we pin OpenVoiceOS/OVOS-workshop#206 here i think #420 can be closed

@JarbasAl JarbasAl added bug Something isn't working mycroft-sync cherry pick from upstream labels May 28, 2024
@JarbasAl JarbasAl requested review from mikejgray, NeonDaniel and a team May 28, 2024 06:31
@JarbasAl JarbasAl added this to the 0.0.8 milestone May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.31%. Comparing base (3cf75ed) to head (d39739b).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #485   +/-   ##
=======================================
  Coverage   74.31%   74.31%           
=======================================
  Files          15       15           
  Lines        2815     2815           
=======================================
  Hits         2092     2092           
  Misses        723      723           
Flag Coverage Δ
unittests 74.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit f63aa3f into dev May 28, 2024
3 checks passed
@JarbasAl JarbasAl deleted the fix/mycroft_compat branch May 28, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mycroft-sync cherry pick from upstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant