Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back backwards-compat imports #434

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Conversation

NeonDaniel
Copy link
Member

Adds missing mycroft.util.record reference
Fixes AdaptIntent for backwards compat.
Closes #433

Fixes `AdaptIntent` for backwards compat.
@NeonDaniel NeonDaniel force-pushed the FIX_BackwardsCompatImports branch from bf4468f to d1b1f44 Compare April 4, 2024 00:47
@JarbasAl JarbasAl added the bug Something isn't working label Apr 4, 2024
@JarbasAl JarbasAl added this to the 0.0.8 milestone Apr 4, 2024
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.01%. Comparing base (b5c8552) to head (de090eb).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #434   +/-   ##
=======================================
  Coverage   67.01%   67.01%           
=======================================
  Files          15       15           
  Lines        2589     2589           
=======================================
  Hits         1735     1735           
  Misses        854      854           
Flag Coverage Δ
unittests 67.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NeonDaniel NeonDaniel marked this pull request as ready for review April 4, 2024 01:09
@NeonDaniel NeonDaniel requested a review from a team April 4, 2024 19:46
@JarbasAl JarbasAl merged commit e14b6e2 into dev Apr 5, 2024
4 checks passed
@JarbasAl JarbasAl deleted the FIX_BackwardsCompatImports branch April 5, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing backwards-compat. imports
2 participants