Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #411

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Update README.md #411

merged 2 commits into from
Feb 14, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Feb 4, 2024

unmycrofity the readme for core 0.0.8

unmycrofity the readme for core 0.0.8
@JarbasAl JarbasAl added the documentation Improvements or additions to documentation label Feb 4, 2024
@JarbasAl JarbasAl requested a review from mikejgray February 4, 2024 13:02
@JarbasAl JarbasAl requested a review from goldyfruit February 4, 2024 13:02
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@JarbasAl
Copy link
Member Author

closes #35

@mikejgray mikejgray requested a review from builderjer February 12, 2024 04:36
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 351 lines in your changes are missing coverage. Please review.

Comparison is base (972b319) 63.41% compared to head (34e3478) 56.75%.
Report is 13 commits behind head on dev.

❗ Current head 34e3478 differs from pull request most recent head 20a70f8. Consider uploading reports for the commit 20a70f8 to get more accurate results

Files Patch % Lines
ovos_core/intent_services/ocp_service.py 28.15% 347 Missing ⚠️
ovos_core/intent_services/__init__.py 75.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #411      +/-   ##
==========================================
- Coverage   63.41%   56.75%   -6.66%     
==========================================
  Files          14       15       +1     
  Lines        2069     2562     +493     
==========================================
+ Hits         1312     1454     +142     
- Misses        757     1108     +351     
Flag Coverage Δ
unittests 56.75% <29.94%> (-6.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@builderjer builderjer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@JarbasAl JarbasAl merged commit 21adbc4 into dev Feb 14, 2024
1 of 3 checks passed
@JarbasAl JarbasAl deleted the refactor/readme branch February 14, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants