Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "ovos.utterance.cancelled" event #404

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

JarbasAl
Copy link
Member

emit a bus event and exit faster if utterance is canceled

example cancel plugin https://github.com/OpenVoiceOS/ovos-utterance-plugin-cancel

emit a bus event and exit faster if utterance is canceled

example cancel plugin https://github.com/OpenVoiceOS/ovos-utterance-plugin-cancel
@JarbasAl JarbasAl added the enhancement New feature or request label Jan 24, 2024
@JarbasAl JarbasAl requested review from goldyfruit and a team January 24, 2024 16:55
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9b03537) 63.48% compared to head (66d9403) 63.41%.
Report is 1 commits behind head on dev.

Files Patch % Lines
ovos_core/intent_services/__init__.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #404      +/-   ##
==========================================
- Coverage   63.48%   63.41%   -0.08%     
==========================================
  Files          14       14              
  Lines        2065     2069       +4     
==========================================
+ Hits         1311     1312       +1     
- Misses        754      757       +3     
Flag Coverage Δ
unittests 63.41% <40.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goldyfruit
Copy link
Member

Works for me,

@JarbasAl JarbasAl merged commit 972b319 into dev Jan 24, 2024
3 of 5 checks passed
@JarbasAl JarbasAl deleted the add-"ovos.utterance.cancelled"-event branch January 24, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants