If a skill exists but the instance is None then reload it #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Presumably it tried to reload and there was an instantiation error. This often happens during development with automatic reloads. Signed-off-by: David Greaves <[email protected]>
|
See also : OpenVoiceOS/OVOS-workshop#173 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #397 +/- ##
==========================================
- Coverage 60.90% 60.70% -0.21%
==========================================
Files 13 13
Lines 1857 1878 +21
==========================================
+ Hits 1131 1140 +9
- Misses 726 738 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Closing
|
|
Hello
👋
сб, 6 янв. 2024 г., 22:44 David Greaves ***@***.***>:
… Closing
After discussions:
- The "load skills from a folder" feature is going away
- This will retry forever
- There are issues if the skill launches threads etc which are hard to
clean up
- There is an ovos-skill-launcher which is a better option for
development use
—
Reply to this email directly, view it on GitHub
<#397 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHJU6HH2Z5ST43UEUQEC6LDYNGEQJAVCNFSM6AAAAABBPUMTAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZZG43DKNJTGM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presumably it tried to reload and there was an instantiation error. This often happens during development with automatic reloads.