Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unittests/skill_self_activation #360

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Oct 2, 2023

No description provided.

@JarbasAl JarbasAl added the tests and automation added unittests or github workflows label Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (280d9a1) 58.42% compared to head (596489d) 59.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #360      +/-   ##
==========================================
+ Coverage   58.42%   59.48%   +1.05%     
==========================================
  Files          13       13              
  Lines        1845     1851       +6     
==========================================
+ Hits         1078     1101      +23     
+ Misses        767      750      -17     
Flag Coverage Δ
unittests 59.48% <100.00%> (+1.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ovos_core/intent_services/converse_service.py 77.65% <100.00%> (+10.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit c2bb2e0 into dev Oct 2, 2023
5 checks passed
@JarbasAl JarbasAl deleted the unittests/skill_self_activation branch October 2, 2023 03:55
@JarbasAl JarbasAl mentioned this pull request Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests and automation added unittests or github workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant