Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unittests/fallback_service #357

Merged
merged 10 commits into from
Sep 30, 2023
Merged

unittests/fallback_service #357

merged 10 commits into from
Sep 30, 2023

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl added the tests and automation added unittests or github workflows label Sep 30, 2023
@JarbasAl
fallback/no_make_active
b54407c 
let the intent service handle this, unittests in core uncovered duplicate messages this commit is fixing
@JarbasAl
frm github
077fe8c
@JarbasAl JarbasAl mentioned this pull request Sep 30, 2023
Merged
@codecov
Copy link

codecov bot commented Sep 30, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ef5f3de) 56.04% compared to head (bc46138) 56.04%.
Report is 1 commits behind head on dev.

Additional details and impacted files 
@@           Coverage Diff           @@
##              dev     #357   +/-   ##
=======================================
  Coverage   56.04%   56.04%           
=======================================
  Files          13       13           
  Lines        1845     1845           
=======================================
  Hits         1034     1034           
  Misses        811      811
Files Coverage Δ
ovos_core/version.py 76.92% <100.00%> (ø)
ovos_core/intent_services/fallback_service.py 43.95% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl marked this pull request as ready for review September 30, 2023 16:09
@JarbasAl JarbasAl merged commit 0c36d16 into dev Sep 30, 2023
10 checks passed
@JarbasAl JarbasAl deleted the unittests/fallback_service branch September 30, 2023 16:11
@JarbasAl JarbasAl mentioned this pull request Sep 30, 2023
Closed
@JarbasAl JarbasAl added this to the 0.0.8 milestone Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tests and automation added unittests or github workflows
Projects
None yet
Milestone
0.0.8
Development

Successfully merging this pull request may close these issues.
1 participant
@JarbasAl