fix/credentials_leaking_in_logs (#403)

TTS/STT credentials can be accidentally leaked in LOGS via Session in message.context
OpenVoiceOS · Jan 24, 2024 · 9b03537 · 9b03537
1 parent 4e0772f
commit 9b03537
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/ovos_core/transformers.py b/ovos_core/transformers.py
@@ -57,7 +57,8 @@ def transform(self, utterances: List[str], context: Optional[dict] = None):
         for module in self.plugins:
             try:
                 utterances, data = module.transform(utterances, context)
-                LOG.debug(f"{module.name}: {data}")
+                _safe = {k:v for k,v in data.items() if k != "session"}  # no leaking TTS/STT creds in logs    
+                LOG.debug(f"{module.name}: {_safe}")
                 context = merge_dict(context, data)
             except Exception as e:
                 LOG.warning(f"{module.name} transform exception: {e}")
@@ -111,8 +112,9 @@ def transform(self, context: Optional[dict] = None):
 
         for module in self.plugins:
             try:
-                data = module.transform(context)
-                LOG.debug(f"{module.name}: {data}")
+                data = module.transform(context)                
+                _safe = {k:v for k,v in data.items() if k != "session"}  # no leaking TTS/STT creds in logs    
+                LOG.debug(f"{module.name}: {_safe}")
                 context = merge_dict(context, data)
             except Exception as e:
                 LOG.warning(f"{module.name} transform exception: {e}")