hotfix/avoid_c++_crash #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partially mitigates OVOSHatchery/ovos-bus-server#2 not a proper fix, but makes it more usable, at least in buildroot it seems functional low impact in latency since these scripts are not meant to be real time, they start a new bus connection etc and are already slow
|
Will see if I can do some testing in the upcoming days however I think @goldyfruit has the best test case. I have to do my best to crash it, where other can crash it with any cli tool connection. |
j1nx
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Managed to do some manual code adjustd testing last evening and was no longer able to crash the bus-server.
But than again, it was already hard to do.
I believe @goldyfruit did the exact same manual code adjustments even before me as he said in the issue tracker which solved it for him as well.
goldyfruit
approved these changes
Jan 9, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially mitigates OVOSHatchery/ovos-bus-server#2
not a proper fix, but makes it more usable, at least in buildroot it seems functional
low impact in latency since these scripts are not meant to be real time, they start a new bus connection etc and are already slow