Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/tts_prefs #64

Merged
merged 2 commits into from
Dec 8, 2023
Merged

feat/tts_prefs #64

merged 2 commits into from
Dec 8, 2023

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Dec 8, 2023

allow a preferred TTS voice or STT model to be specified per request

@JarbasAl JarbasAl added the enhancement New feature or request label Dec 8, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e36dbeb) 52.61% compared to head (4a74f44) 53.12%.
Report is 2 commits behind head on dev.

Files Patch % Lines
ovos_bus_client/version.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #64      +/-   ##
==========================================
+ Coverage   52.61%   53.12%   +0.50%     
==========================================
  Files          14       14              
  Lines        1108     1120      +12     
==========================================
+ Hits          583      595      +12     
  Misses        525      525              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

JarbasAl added a commit to OpenVoiceOS/ovos-plugin-manager that referenced this pull request Dec 8, 2023
refactor cache handling out of base TTS class

allow TTS preferences to come from Session OpenVoiceOS/ovos-bus-client#64
allow a preferred TTS voice or STT model to be specified per request
@JarbasAl JarbasAl merged commit b049eb8 into dev Dec 8, 2023
7 checks passed
@JarbasAl JarbasAl deleted the feat/tts_prefs branch December 8, 2023 19:53
This was referenced Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants