Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm/valid_langs_session #57

Merged
merged 3 commits into from
Oct 23, 2023
Merged

rm/valid_langs_session #57

merged 3 commits into from
Oct 23, 2023

Conversation

JarbasAl
Copy link
Member

valid languages are defined by core in mycroft.conf , these can not come from Session

core is the authority about what languages it natively supports, session can only assign the current language

if session claims to support a language that core did not load / register intent for that will cause issues, adding this was an oversight

valid languages are defined by core in mycroft.conf , these can not come from Session

core is the authority about what languages it natively supports, session can only assign the current language

if session claims to support a language that core did not load / register intent for that will cause issues, adding this was an oversight
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 34 lines in your changes are missing coverage. Please review.

Comparison is base (6616569) 53.58% compared to head (067cec4) 52.92%.
Report is 8 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #57      +/-   ##
==========================================
- Coverage   53.58%   52.92%   -0.67%     
==========================================
  Files          14       14              
  Lines        1073     1111      +38     
==========================================
+ Hits          575      588      +13     
- Misses        498      523      +25     
Files Coverage Δ
ovos_bus_client/client/waiter.py 82.75% <100.00%> (+3.59%) ⬆️
ovos_bus_client/version.py 0.00% <0.00%> (ø)
ovos_bus_client/client/client.py 37.61% <75.00%> (+3.18%) ⬆️
ovos_bus_client/session.py 55.24% <33.33%> (-0.32%) ⬇️
ovos_bus_client/scripts.py 11.94% <6.45%> (-4.73%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit fcc8a41 into dev Oct 23, 2023
6 of 7 checks passed
@JarbasAl JarbasAl deleted the rm/valid_langs branch October 23, 2023 21:39
This was referenced Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant