Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add simple_cli entrypoint #56

Merged
merged 4 commits into from
Oct 16, 2023
Merged

add simple_cli entrypoint #56

merged 4 commits into from
Oct 16, 2023

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Oct 16, 2023

ensure bus connection on cli utils

add a simple_cli for testing

@JarbasAl JarbasAl added the bug Something isn't working label Oct 16, 2023
@JarbasAl JarbasAl requested a review from emphasize October 16, 2023 18:27
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (6616569) 53.58% compared to head (70d3a60) 53.33%.
Report is 5 commits behind head on dev.

❗ Current head 70d3a60 differs from pull request most recent head 3d3efcb. Consider uploading reports for the commit 3d3efcb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #56      +/-   ##
==========================================
- Coverage   53.58%   53.33%   -0.25%     
==========================================
  Files          14       14              
  Lines        1073     1108      +35     
==========================================
+ Hits          575      591      +16     
- Misses        498      517      +19     
Files Coverage Δ
ovos_bus_client/client/waiter.py 82.75% <100.00%> (+3.59%) ⬆️
ovos_bus_client/version.py 0.00% <0.00%> (ø)
ovos_bus_client/client/client.py 37.61% <75.00%> (+3.18%) ⬆️
ovos_bus_client/scripts.py 13.33% <8.33%> (-3.34%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl added enhancement New feature or request and removed bug Something isn't working labels Oct 16, 2023
@JarbasAl JarbasAl changed the title ensure bus connection on cli utils add simple_cli entrypoint Oct 16, 2023
@JarbasAl JarbasAl merged commit f3659c2 into dev Oct 16, 2023
6 checks passed
@JarbasAl JarbasAl deleted the fix/ensure_bus_connected branch October 16, 2023 18:37
This was referenced Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants