fix: resolve image urls

[JarbasAl]

when image paths are not absolute resolve them from gui cache if possible

Summary by CodeRabbit

• New Features

  • Improved image handling in the GUI with enhanced URL resolution for images.

• Bug Fixes

  • Resolved issues with image display when provided URLs were invalid or inaccessible, ensuring more robust error handling.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce a new private method _resolve_url in the GUIInterface class, which resolves URLs to valid file paths. This method checks if the URL is a valid non-empty string starting with "http" and normalizes it if necessary. The show_image and show_animated_image methods are updated to use _resolve_url, ensuring that the URLs are resolved before proceeding with image handling. This modification enhances the control flow and robustness of the image display functionality in the GUI.

Changes

File Path	Change Summary
ovos_bus_client/apis/gui.py	Added method _resolve_url to resolve URLs to file paths; modified show_image and show_animated_image to use this method for URL validation.

Possibly related PRs

• fix: resolve image urls #136: The changes in this PR directly match the main PR, as both introduce the _resolve_url method in the GUIInterface class and modify the show_image and show_animated_image methods to utilize this new method for resolving image URLs.

Poem

In the code where images play,
A rabbit hops, brightening the day.
With paths resolved, no more to fret,
A gallery of joy, we won't forget!
So let us cheer for this new way,
Where every image finds its stay! 🐇✨

Warning

Rate limit exceeded

@github-actions[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 8 minutes and 43 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between fd84a56 and 38ea4f1.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

🧹 Outside diff range and nitpick comments (1)

ovos_bus_client/apis/gui.py (1)

575-578: Improve error handling in show_image

Consider raising an exception or notifying the user when an image fails to load.

         url = self._resolve_url(url)
         if not os.path.isfile(url):
-            LOG.error(f"Provided image file does not exist! '{url}'")
+            error_msg = f"Provided image file does not exist! '{url}'"
+            LOG.error(error_msg)
+            self.show_text(error_msg, "Image Load Error")
             return

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 7318b50 and fd84a56.

📒 Files selected for processing (1)

• ovos_bus_client/apis/gui.py (3 hunks)

🔇 Additional comments (1)

ovos_bus_client/apis/gui.py (1)

Line range hint 536-614: Verify impact on existing skills

Let's verify if any skills might be affected by the URL resolution changes.