fix/ocp_api_context #103
Merged
fix/ocp_api_context #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
classic audio service api did not ensure correct message.context add optional kwarg for source message, in some cases dig_for_message returns None (unsure when it happens, but issues noticed with hivemind)
JarbasAl
added a commit
to OpenVoiceOS/ovos-core
that referenced
this pull request
Jul 12, 2024
pass kwarg for source message, in some cases dig_for_message returns None (unsure when it happens, but issues noticed with hivemind) companion to OpenVoiceOS/ovos-bus-client#103
JarbasAl
added a commit
to OpenVoiceOS/ovos-core
that referenced
this pull request
Jul 12, 2024
* fix/ocp_api_context pass kwarg for source message, in some cases dig_for_message returns None (unsure when it happens, but issues noticed with hivemind) companion to OpenVoiceOS/ovos-bus-client#103 * requirements.txt * fix/ocp_missing_context the OCP query messages were dropping message source and destination * fix/ocp_missing_context missed OCPQuery class in previous PR
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
classic audio service api did not ensure correct message.context
add optional kwarg for source message, in some cases dig_for_message returns None (unsure when it happens, but issues noticed with hivemind)