Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/improve_legacy_support #63

Merged
merged 8 commits into from
May 9, 2024
Merged

feat/improve_legacy_support #63

merged 8 commits into from
May 9, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented May 9, 2024

better readme + expose ocp flag to config

preparing for stable release

better readme + expose ocp flag to config
@JarbasAl JarbasAl added the enhancement New feature or request label May 9, 2024
@JarbasAl JarbasAl requested review from NeonDaniel and a team May 9, 2024 02:48
Copy link
Contributor

@mikejgray mikejgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

> **NOTE:** once ovos-media is released OCP and this api will be disabled by default and deprecated!

```javascript
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion(non-blocking): use ```json for better formatting, potentially?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

markdown rendering in github doesnt like comments, thats why i use javascript usually, avoids the red highlights as it would be invalid json but is a valid javascript comment

@JarbasAl JarbasAl merged commit 1722bf4 into dev May 9, 2024
4 checks passed
@JarbasAl JarbasAl deleted the feat/improve_legacy_support branch May 9, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants