Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix - 3 second delay on listen sound #46

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Dec 29, 2023

if alsa plugin is not present to answer the mute/unmute messages there was a 3 second timeout

this makes it tolerable

removes a old kludge for mycroft metrics to avoid log spam around the deprecated mycroft import

if alsa plugin is not present to answer the mute/unmute messages
@JarbasAl JarbasAl added the bug Something isn't working label Dec 29, 2023
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (dev@958e364). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev     #46   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?       8           
  Lines          ?     953           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?     953           
  Partials       ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit 27f2a11 into dev Dec 29, 2023
5 checks passed
@JarbasAl JarbasAl deleted the fix/listen_sound_delay branch December 29, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant