refactor/skill_settings_change

[JarbasAl]

companion to OpenVoiceOS/ovos-core#325

once that PR is merged we can do a version check to ensure compatibility with older core versions, it should be merged first

[mikejgray]

This looks fine in terms of the code, but I'm not sure how to even test it works as expected. Not familiar enough with this portion of the codebase yet

[codecov]

Codecov Report

Attention: Patch coverage is 58.33333% with 5 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (dev@80deb75). Click here to learn what that means.

Files	Patch %	Lines
ovos_workshop/skills/ovos.py	58.33%	5 Missing ⚠️

Additional details and impacted files

@@          Coverage Diff           @@
##             dev      #92   +/-   ##
======================================
  Coverage       ?   54.07%           
======================================
  Files          ?       36           
  Lines          ?     3752           
  Branches       ?        0           
======================================
  Hits           ?     2029           
  Misses         ?     1723           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JarbasAl]

@goldyfruit does over docker share the XDG directory for skill settings between skill volumes and core container?

not sure what the default for the docker flag should be

ovos-core is monitoring the folder for changes in settings.json , and emits a bus event when detected, depending if it has access to the volume or not i need to account for that here, either skills need to monitor their own file separately or can just wait for core events (less threads running)

[goldyfruit]

Yes, ovos_core and ovos_skill_* containers share ~/.config/mycroft/.

[goldyfruit]

https://github.com/OpenVoiceOS/ovos-docker/blob/dev/base/Dockerfile#L37