fix: voc_match ignore case

[JarbasAl]

Summary by CodeRabbit

• New Features

  • Enhanced vocabulary matching for case insensitivity, improving user input flexibility.
  • Added warning log for missing vocabulary files, providing better feedback to users.

• Bug Fixes

  • Resolved issues with exact match comparisons by implementing case-insensitive checks.

[coderabbitai]

Walkthrough

The changes focus on enhancing the vocabulary matching functionality in the OVOSSkill class within the ovos_workshop/skills/ovos.py file. The modifications improve case sensitivity for vocabulary matching by converting utterances and vocabulary items to lowercase during comparison. A new warning log has been added to handle scenarios where a vocabulary file is not found, providing language-specific feedback. These updates aim to make the vocabulary matching process more robust and flexible.

Changes

File	Change Summary
ovos_workshop/skills/ovos.py	- Updated voc_match method to use case-insensitive matching - Added lowercase conversion for exact matches - Included re.IGNORECASE flag for regex matching - Added warning log for missing vocabulary files

Poem

🐰 Vocab matching, oh so bright,
Case-insensitive, pure delight!
Lowercase magic, regex's might,
No more worries of upper or lower's fight,
Skill's language learning takes flight! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 49.66%. Comparing base (dc51ea7) to head (08e6320).
Report is 11 commits behind head on dev.

Files with missing lines	Patch %	Lines
ovos_workshop/skills/ovos.py	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #312      +/-   ##
==========================================
- Coverage   49.89%   49.66%   -0.23%     
==========================================
  Files          37       37              
  Lines        4341     4357      +16     
==========================================
- Hits         2166     2164       -2     
- Misses       2175     2193      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

ovos_workshop/skills/ovos.py (1)

2175-2175: Use re.escape() for special characters
When building a regular expression from external strings, it is safer to use re.escape(i) to avoid unintended behavior if i contains special regex characters (e.g., punctuation or parentheses). As a small performance improvement, consider passing a generator to any(), instead of a pre-built list.

- match = any([re.match(r'.*\b' + i + r'\b.*', utt, re.IGNORECASE)
-              for i in _vocs])
+ match = any(
+     re.match(r'.*\b' + re.escape(i) + r'\b.*', utt, re.IGNORECASE)
+     for i in _vocs
+ )

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2e49269 and 08e6320.

📒 Files selected for processing (1)

• ovos_workshop/skills/ovos.py (1 hunks)

🔇 Additional comments (3)

ovos_workshop/skills/ovos.py (3)

2160-2160: Good fallback usage for language selection
The inline assignment ensures that if lang is not provided, self.lang is used as a fallback. This is clear and concise.

---

2165-2165: Great logging for missing vocabulary files
Logging a warning is a good approach to keep track of missing vocab resources. Consider confirming that higher-level application logic or catch blocks handle this scenario appropriately, so users understand why a vocabulary match fails.

---

2171-2171: Correct case-insensitive exact match check
By comparing both the vocab entry and the utterance in lowercase, the code reliably performs exact matching without case issues. This effectively addresses the PR objective.