feat: game skill #306
feat: game skill #306
Conversation
WalkthroughThe pull request introduces significant updates to the Changes
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (7)
🚧 Files skipped from review as they are similar to previous changes (5)
🧰 Additional context used🪛 Ruff (0.8.2)ovos_workshop/skills/game_skill.py46-46: Star-arg unpacking after a keyword argument is strongly discouraged (B026) 🔇 Additional comments (9)ovos_workshop/skills/game_skill.py (7)
The
The
The state properties are well-implemented:
The pause/resume methods:
The deactivation handler:
Fix constructor argument ordering. The constructor violates Python's argument ordering convention. Star args should come before keyword arguments. Apply this fix: - def __init__(self, skill_voc_filename: str,
- *args,
- skill_icon: str = "",
- game_image: str = "",
- **kwargs):
+ def __init__(self, skill_voc_filename: str,
+ skill_icon: str = "",
+ game_image: str = "",
+ *args,
+ **kwargs):
🧰 Tools🪛 Ruff (0.8.2)46-46: Star-arg unpacking after a keyword argument is strongly discouraged (B026)
Add error handling for dialog file loading. The save/load methods should handle potential errors when loading dialog files. Apply this fix: def on_save_game(self):
"""skills can override method to implement functioonality"""
+ try:
speech = _get_dialog("cant_save_game", self.lang)
self.speak(speech)
+ except Exception as e:
+ self.log.error(f"Failed to load save game dialog: {e}")
+ self.speak("Unable to save game")
def on_load_game(self):
"""skills can override method to implement functioonality"""
+ try:
speech = _get_dialog("cant_load_game", self.lang)
self.speak(speech)
+ except Exception as e:
+ self.log.error(f"Failed to load load game dialog: {e}")
+ self.speak("Unable to load game")
ovos_workshop/skills/common_play.py (2)
The handler invocation:
The stop handler:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
ovos_workshop/skills/game_skill.py (3)
39-39: Refactor star-arg unpacking after keyword arguments per style guidelines
Static analysis flags this line due to star-arg usage after keyword arguments. While it may still work, it's generally discouraged for readability and maintainability.Consider rearranging the arguments or removing the star-arg if not strictly necessary.
- super().__init__(skill_icon=skill_icon, skill_voc_filename=skill_voc_filename, - supported_media=[MediaType.GAME], *args, **kwargs) + super().__init__( + skill_voc_filename=skill_voc_filename, + skill_icon=skill_icon, + supported_media=[MediaType.GAME], + *args, **kwargs + )🧰 Tools
🪛 Ruff (0.8.2)
39-39: Star-arg unpacking after a keyword argument is strongly discouraged
(B026)
168-180: Clarify fallback behavior in "will_trigger"
"will_trigger" returns True only if this skill is the top intent. If multiple game skills could exist, a fallback mechanism might be needed to handle partial matches or to disambiguate among games.
197-199: Consider separating abandon and stop actions
"on_abandon_game()" is called immediately before "on_stop_game()" here. If the user’s intention is to return to the main menu (not necessarily to stop the session), you might consider letting them request a resume later.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
ovos_workshop/skills/game_skill.py(1 hunks)
🧰 Additional context used
🪛 Ruff (0.8.2)
ovos_workshop/skills/game_skill.py
39-39: Star-arg unpacking after a keyword argument is strongly discouraged
(B026)
🔇 Additional comments (2)
ovos_workshop/skills/game_skill.py (2)
75-82: Verify that 'Playlist' indexing is supported
Here, "_ocp_featured()" returns a 'Playlist' object, but you're accessing "[0]". Confirm that 'Playlist' implements indexing or if you should access 'Playlist.tracks[0]' instead.
✅ Verification successful
Since we found that Playlist inherits from list in ovos_workshop/backwards_compat.py, it automatically supports indexing operations. The class definition class Playlist(list): clearly shows that Playlist is a subclass of Python's built-in list type, which means it inherits all list functionality including indexing operations.
Indexing operation is supported, code is correct
The current implementation accessing _ocp_featured()[0] is valid since Playlist inherits from list and therefore supports standard list indexing operations. No changes needed.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Checking if 'Playlist' in ovos_utils.ocp or related references implement indexing.
rg -A 10 "class Playlist"
Length of output: 738
110-115: Ensure concurrency safety when stopping a running game
The 'stop()' method checks 'is_playing' and invokes 'on_stop_game()' if true. Verify that no concurrency issues arise if multiple stop requests arrive concurrently.
✅ Verification successful
Let me search for more context about the game skill implementation and any threading/concurrency related code.
Let me check the GameSkill class implementation to understand how the _playing Event is used.
Let me try a different approach to find the GameSkill implementation.
Let me check the full game_skill.py file to understand the complete implementation.
Concurrency is properly handled in the game skill implementation
The implementation is thread-safe because:
- The
is_playingstate is managed using a threading Event (self._playing) inherited fromOVOSCommonPlaybackSkill - The Event object is thread-safe by design and atomic in its operations
- The
stop()method's check-then-act pattern is safe because Event'sis_set()and the subsequenton_stop_game()call cannot be interrupted
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Searching for concurrency control (threading lock or event usage) in OVOSCommonPlaybackSkill
rg -A 10 "class OVOSCommonPlaybackSkill"
Length of output: 747
Script:
#!/bin/bash
# Search for the game skill class definition and implementation
ast-grep --pattern 'class GameSkill {
$$$
}'
# Search for any threading/lock related imports and usage
rg -l "import threading|from threading"
rg "Lock\(\)|Event\(\)|RLock\(\)"
# Search for is_playing property/variable definition
rg -A 5 "is_playing"
Length of output: 2749
Script:
#!/bin/bash
# Search for GameSkill class implementation
rg -A 20 "class GameSkill"
# Search for on_stop_game implementation
ast-grep --pattern 'def on_stop_game($$$) {
$$$
}'
Length of output: 83
Script:
#!/bin/bash
# Search for GameSkill class with different quotes
rg -A 20 'class GameSkill\('
# Search for the file containing GameSkill
fd GameSkill
# Try to find on_stop_game implementation with different pattern
rg -A 5 "def on_stop_game"
Length of output: 857
Script:
#!/bin/bash
# Get the full content of game_skill.py
cat ovos_workshop/skills/game_skill.py
Length of output: 7718
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #306 +/- ##
==========================================
- Coverage 53.41% 49.89% -3.52%
==========================================
Files 37 37
Lines 4362 4341 -21
==========================================
- Hits 2330 2166 -164
- Misses 2032 2175 +143 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (4)
ovos_workshop/skills/game_skill.py (4)
26-27: Track TODOs for OCP pipeline integrationThe comments indicate missing intents in the OCP pipeline for game-specific actions (save/load).
Would you like me to create GitHub issues to track the implementation of these game-specific intents in the OCP pipeline?
87-113: Enhance abstract method documentationThe abstract methods would benefit from more detailed docstrings including:
- Parameters and return types
- Example usage
- Error conditions
Would you like me to provide enhanced docstring templates for these methods?
124-127: Consider making the intent timeout configurableThe hardcoded 0.5 second timeout in
calc_intentmight be too short for some systems or too long for others.Consider making this configurable:
+ def __init__(self, skill_voc_filename: str, + *args, + skill_icon: str = "", + game_image: str = "", + intent_timeout: float = 0.5, + **kwargs): + self.intent_timeout = intent_timeout + ... def calc_intent(self, utterance: str, lang: str) -> Optional[Dict[str, str]]: response = self.bus.wait_for_response(Message("intent.service.intent.get", {"utterance": utterance, "lang": lang}), "intent.service.intent.reply", - timeout=0.5) + timeout=self.intent_timeout)
13-207: Consider enhancing the game framework with additional featuresThe current implementation provides a solid foundation, but consider these enhancements:
- Add support for game state persistence
- Include game metrics collection (playtime, completion rate, etc.)
- Add support for multiplayer games
- Consider implementing a game event system for achievements/milestones
Would you like me to provide detailed implementation suggestions for any of these features?
🧰 Tools
🪛 Ruff (0.8.2)
39-39: Star-arg unpacking after a keyword argument is strongly discouraged
(B026)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
ovos_workshop/skills/game_skill.py(1 hunks)
🧰 Additional context used
🪛 Ruff (0.8.2)
ovos_workshop/skills/game_skill.py
39-39: Star-arg unpacking after a keyword argument is strongly discouraged
(B026)
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
ovos_workshop/skills/game_skill.py (2)
177-191: Improve documentation for will_trigger methodThe method's docstring could be clearer about its return value and usage pattern.
Consider updating the docstring:
def will_trigger(self, utterance: str, lang: str) -> bool: - """helper to check if this skill would be selected by ovos-core with the given utterance - - useful in converse method - eg. return not self.will_trigger - - this example allows the utterance to be consumed via converse of using ovos-core intent parser - ensuring it is always handled by the game skill regardless - """ + """Check if this skill would be selected by ovos-core for the given utterance. + + Args: + utterance (str): The user's spoken input + lang (str): The language code + + Returns: + bool: True if ovos-core would select this skill for the utterance, + False otherwise + + Usage: + In converse method, use `not self.will_trigger(utterance, lang)` + to ensure game commands are handled even when they don't match + any specific intent. + """
13-133: Consider adding game state management capabilitiesThe base class provides a solid foundation for game implementation, but could benefit from some additional architectural considerations:
- Consider adding a game state management system to help implementations track and persist game states consistently
- Think about adding hooks for analytics/telemetry to track game usage and user engagement
- Consider adding rate limiting or cooldown mechanisms for game commands to prevent spam
These additions would make the framework more robust for production use.
Would you like assistance in implementing any of these suggestions?
🧰 Tools
🪛 Ruff (0.8.2)
40-40: Star-arg unpacking after a keyword argument is strongly discouraged
(B026)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
ovos_workshop/skills/game_skill.py(1 hunks)
🧰 Additional context used
🪛 Ruff (0.8.2)
ovos_workshop/skills/game_skill.py
40-40: Star-arg unpacking after a keyword argument is strongly discouraged
(B026)
🔇 Additional comments (5)
ovos_workshop/skills/game_skill.py (5)
1-11: LGTM! Well-organized imports with proper type hints
The imports are comprehensive and properly organized, including all necessary components for OCP integration and type hinting.
47-83: LGTM! Well-implemented OCP integration
The OCP integration is robust with:
- Proper featured media handling with confidence scoring
- Efficient game name matching using Damerau-Levenshtein similarity
- Appropriate media type filtering
192-200: Add error handling in converse method
The converse method should handle potential exceptions when processing utterances.
202-209: Add error handling in handle_deactivate method
The deactivation handler should gracefully handle errors to ensure proper cleanup.
32-40:
Fix constructor argument ordering
The constructor violates Python's argument ordering convention by having *args after a keyword argument.
Apply this fix:
def __init__(self, skill_voc_filename: str,
+ *args,
skill_icon: str = "",
game_image: str = "",
- *args, **kwargs):
+ **kwargs):
self.game_image = game_image
super().__init__(skill_icon=skill_icon, skill_voc_filename=skill_voc_filename,
supported_media=[MediaType.GAME], *args, **kwargs)Likely invalid or redundant comment.
🧰 Tools
🪛 Ruff (0.8.2)
40-40: Star-arg unpacking after a keyword argument is strongly discouraged
(B026)
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
ovos_workshop/skills/game_skill.py (2)
32-47: Consider adding parameter validation in constructor.The constructor properly initializes the game skill with required parameters, but could benefit from additional validation.
Consider adding validation:
def __init__(self, skill_voc_filename: str, *args, skill_icon: str = "", game_image: str = "", **kwargs): + if not skill_voc_filename: + raise ValueError("skill_voc_filename is required for OCP integration") self.game_image = game_image super().__init__(skill_icon=skill_icon, skill_voc_filename=skill_voc_filename, supported_media=[MediaType.GAME], *args, **kwargs)🧰 Tools
🪛 Ruff (0.8.2)
41-41: Star-arg unpacking after a keyword argument is strongly discouraged
(B026)
150-161: Consider adding sound effects for pause/resume.The pause/resume handlers could benefit from audio feedback.
Consider adding sound effects:
def on_pause_game(self): """called by ocp_pipeline on 'pause' if game is being played""" # TODO - default dialog/sound self._paused.set() + self.play_audio('snd/game_pause.mp3', instant=True) self.acknowledge() def on_resume_game(self): """called by ocp_pipeline on 'resume/unpause' if game is being played and paused""" # TODO - default dialog/sound self._paused.clear() + self.play_audio('snd/game_resume.mp3', instant=True) self.acknowledge()
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
ovos_workshop/locale/en/cant_load_game.dialog(1 hunks)ovos_workshop/locale/en/cant_save_game.dialog(1 hunks)ovos_workshop/skills/common_play.py(5 hunks)ovos_workshop/skills/game_skill.py(1 hunks)ovos_workshop/skills/ovos.py(2 hunks)
✅ Files skipped from review due to trivial changes (2)
- ovos_workshop/locale/en/cant_load_game.dialog
- ovos_workshop/locale/en/cant_save_game.dialog
🧰 Additional context used
🪛 Ruff (0.8.2)
ovos_workshop/skills/game_skill.py
41-41: Star-arg unpacking after a keyword argument is strongly discouraged
(B026)
🔇 Additional comments (10)
ovos_workshop/skills/game_skill.py (6)
13-30: LGTM! Well-documented class purpose and bus events.
The class documentation clearly explains its purpose, integration with OCP, and the required parameters. The bus events are well documented.
48-69: LGTM! Well-implemented OCP featured media integration.
The _ocp_featured method correctly implements the OCP GUI menu integration with proper media entry configuration.
71-84: LGTM! Robust search implementation with confidence threshold.
The _ocp_search method properly implements search functionality with:
- Media type validation
- Confidence scoring
- Threshold-based filtering
94-120: LGTM! Well-defined abstract methods for game lifecycle.
The abstract methods clearly define the required implementations for game lifecycle management:
- play_game
- pause_game
- resume_game
- stop_game
- save_game
- load_game
140-149: LGTM! Well-implemented default save/load game handlers.
The default implementations properly handle the case when save/load functionality is not implemented by using dialog files.
201-220: LGTM! Robust error handling in converse method.
The converse method implementation includes proper error handling for:
- KeyError and IndexError for message data access
- General exception handling with logging
ovos_workshop/skills/common_play.py (3)
76-76: LGTM! Added paused state tracking.
The addition of self._paused = Event() properly tracks the paused state of playback.
395-395: LGTM! Consistent paused state management.
The handlers properly manage the paused state:
- Cleared on play
- Set on pause
- Cleared on resume
- Cleared on stop
Also applies to: 401-401, 411-411, 437-437
551-555: LGTM! Proper cleanup in stop handler.
The _handle_stop method properly cleans up both playing and paused states.
ovos_workshop/skills/ovos.py (1)
1079-1079: LGTM! Improved method visibility.
The change from __handle_stop to _handle_stop improves method visibility while maintaining encapsulation.
Also applies to: 1267-1267
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
ovos_workshop/skills/game_skill.py (3)
14-31: Consider enhancing class documentation.While the docstring provides good information about OCP integration, it would be helpful to:
- Document the purpose and use cases of the class
- Explain the relationship with
OVOSCommonPlaybackSkill- Add examples of implementing game skills
33-48: Consider adding validation for game_image path.The initialization accepts a
game_imageparameter but doesn't validate if the image file exists. This could lead to runtime errors when displaying the game in the GUI.def __init__(self, skill_voc_filename: str, *args, skill_icon: str = "", game_image: str = "", **kwargs): """IMPORTANT: contents of skill_voc_filename are crucial for intent matching without that ocp_pipeline might not recognize the skill as a game""" + if game_image and not os.path.isfile(game_image): + LOG.warning(f"Game image not found: {game_image}") self.game_image = game_image super().__init__(skill_icon=skill_icon, skill_voc_filename=skill_voc_filename, supported_media=[MediaType.GAME], *args, **kwargs)🧰 Tools
🪛 Ruff (0.8.2)
42-42: Star-arg unpacking after a keyword argument is strongly discouraged
(B026)
180-195: Consider adding documentation for game command handling.The
on_game_commandmethod would benefit from more detailed documentation about:
- Expected format of game commands
- How to handle different command types
- Examples of command processing
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
ovos_workshop/locale/en/cant_load_game.dialog(1 hunks)ovos_workshop/locale/en/cant_save_game.dialog(1 hunks)ovos_workshop/locale/en/game_pause.dialog(1 hunks)ovos_workshop/locale/en/game_unpause.dialog(1 hunks)ovos_workshop/skills/common_play.py(5 hunks)ovos_workshop/skills/game_skill.py(1 hunks)ovos_workshop/skills/ovos.py(2 hunks)
✅ Files skipped from review due to trivial changes (4)
- ovos_workshop/locale/en/game_unpause.dialog
- ovos_workshop/locale/en/cant_save_game.dialog
- ovos_workshop/locale/en/cant_load_game.dialog
- ovos_workshop/locale/en/game_pause.dialog
🧰 Additional context used
🪛 Ruff (0.8.2)
ovos_workshop/skills/game_skill.py
42-42: Star-arg unpacking after a keyword argument is strongly discouraged
(B026)
🔇 Additional comments (10)
ovos_workshop/skills/game_skill.py (6)
1-12: LGTM! Well-organized imports with proper type hints.
The imports are logically grouped and type hints are used appropriately to improve code documentation.
49-70: LGTM! Well-implemented OCP featured media integration.
The _ocp_featured method correctly implements the OCP interface for displaying the game in the GUI menu.
72-85: LGTM! Robust search implementation with confidence threshold.
The _ocp_search method properly handles game name matching with a reasonable confidence threshold of 50%.
87-121: LGTM! Well-defined abstract game lifecycle methods.
The abstract methods clearly define the game lifecycle (play, pause, resume, stop, save, load) with appropriate docstrings.
153-170: LGTM! Well-implemented pause handling with configurable feedback.
The pause implementation properly manages state and provides configurable user feedback.
247-263: LGTM! Robust deactivation handling with auto-save.
The deactivation handler properly manages game state and includes auto-save functionality.
ovos_workshop/skills/common_play.py (3)
76-76: LGTM! Added pause state tracking.
The _paused Event properly tracks pause state for playback control.
395-395: LGTM! Consistent pause state management.
The playback handlers properly manage the pause state across play, pause, resume, and stop operations.
Also applies to: 401-401, 411-411, 437-437
551-555: LGTM! Clean state reset in stop handler.
The stop handler properly clears both playing and paused states.
ovos_workshop/skills/ovos.py (1)
1079-1079: LGTM! Consistent stop handler naming.
The stop handler registration and implementation maintain consistent naming conventions.
Also applies to: 1267-1267
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
ovos_workshop/skills/game_skill.py (1)
219-223: Consider adding error handling to autosave.The
_autosavemethod should handle potential errors during the save operation.Consider this implementation:
def _autosave(self): """helper to save the game automatically if enabled in settings.json and implemented by skill""" - if self.settings.get("auto_save", False) and self.save_is_implemented: - self.on_save_game() + try: + if self.settings.get("auto_save", False) and self.save_is_implemented: + self.on_save_game() + except Exception as e: + self.log.error(f"Auto-save failed: {e}")ovos_workshop/skills/common_play.py (1)
394-396: Consider caching handler signatures.The code repeatedly checks handler signatures in multiple methods. This could be optimized by caching the signatures during initialization.
Consider caching the signatures in the constructor:
def __init__(self, *args, **kwargs): # ... existing code ... + self.__handler_params = { + 'playback': signature(self.__playback_handler).parameters if self.__playback_handler else None, + 'pause': signature(self.__pause_handler).parameters if self.__pause_handler else None, + 'resume': signature(self.__resume_handler).parameters if self.__resume_handler else None, + 'next': signature(self.__next_handler).parameters if self.__next_handler else None, + 'prev': signature(self.__prev_handler).parameters if self.__prev_handler else None + }Then update the handler methods to use the cached signatures:
def __handle_ocp_play(self, message): if self.__playback_handler: - params = signature(self.__playback_handler).parameters - kwargs = {"message": message} if "message" in params else {} + kwargs = {"message": message} if self.__handler_params['playback'] and "message" in self.__handler_params['playback'] else {} self.__playback_handler(**kwargs)Also applies to: 408-410, 420-422, 431-433, 440-442
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
ovos_workshop/skills/common_play.py(5 hunks)ovos_workshop/skills/game_skill.py(1 hunks)
🧰 Additional context used
🪛 Ruff (0.8.2)
ovos_workshop/skills/game_skill.py
46-46: Star-arg unpacking after a keyword argument is strongly discouraged
(B026)
🔇 Additional comments (6)
ovos_workshop/skills/game_skill.py (5)
48-69: LGTM: Well-structured OCP integration.
The _ocp_featured method correctly implements the featured media functionality for OCP GUI integration.
71-84: LGTM: Robust search implementation.
The _ocp_search method properly implements game name matching with confidence scoring.
224-244: LGTM: Robust error handling in converse method.
The method properly handles various error cases and includes appropriate logging.
246-262: LGTM: Well-implemented deactivation handling.
The handle_deactivate method includes proper error handling and state management.
33-46:
Fix constructor argument ordering.
The constructor violates Python's argument ordering convention by having *args after keyword arguments.
Apply this fix:
def __init__(self, skill_voc_filename: str,
+ *args,
skill_icon: str = "",
game_image: str = "",
- *args, **kwargs):
+ **kwargs):
self.game_image = game_image
super().__init__(skill_icon=skill_icon, skill_voc_filename=skill_voc_filename,
supported_media=[MediaType.GAME],
playback_handler=self.on_play_game,
pause_handler=self.on_pause_game,
resume_handler=self.on_resume_game,
*args, **kwargs)Likely invalid or redundant comment.
🧰 Tools
🪛 Ruff (0.8.2)
46-46: Star-arg unpacking after a keyword argument is strongly discouraged
(B026)
ovos_workshop/skills/common_play.py (1)
564-568: LGTM: Clean stop handling implementation.
The _handle_stop method properly cleans up both playing and paused states.
add new base class to make it easy to implement voice games
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
accept both munged and unmunged intent names intentlayers use the munged name preffixed with skill_id: and was failing to enable/disable intents
accept both munged and unmunged intent names intentlayers use the munged name preffixed with skill_id: and was failing to enable/disable intents
JarbasAl
force-pushed
the
feat/gameskill
branch
from
cbada8e to
426f851
Compare
* feat: game skill (#306) * feat: game skill add new base class to make it easy to implement voice games * add resume handler * resume * adjust timeout * Apply suggestions from code review Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * better stop handling * rename method for clarity * implement pause/resume * dont require save/load methods to be implemented * implement autosave setting * tweak when autosave happens * pause game default dialogs« * fix - cant use self.speak_dialog for bundled resource files from ovos-workshop * improve non-decorator usage callback handling --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * Increment Version to 3.2.0a1 * Update Changelog --------- Co-authored-by: JarbasAI <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: JarbasAl <[email protected]>
add new base class to make it easy to implement voice games
example usage:
Summary by CodeRabbit
Summary by CodeRabbit
New Features
OVOSGameSkillfor game playback integration.ConversationalGameSkillfor handling game commands and user interactions.Bug Fixes
Documentation