fix:icon file path

[JarbasAl]

use self.res_dir not self.root_dir to allow non standard locations (eg. OCP)

allow skills to load even if icon is missing, but log an error and dont register app with homescreen

missed in #283 , need for OpenVoiceOS/ovos-ocp-audio-plugin#152

Summary by CodeRabbit

• New Features

  • Enhanced homescreen app registration by sourcing the icon from the resource directory.

• Bug Fixes

  • Added error handling to log messages when the icon file is not found, improving feedback for users.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes in this pull request modify the register_homescreen_app method within the OVOSSkill class. The icon's source path has been updated from self.root_dir to self.res_dir, ensuring the icon is retrieved from the resource directory. Additionally, an error handling mechanism has been added to log an error if the icon file is not found at the new location. The overall functionality of the class remains unchanged, with no other modifications to the logic or control flow.

Changes

File	Change Summary
ovos_workshop/skills/ovos.py	Modified register_homescreen_app method to source the icon from self.res_dir and added error logging for missing icon files.

Possibly related PRs

• feat:skilljson and homescreen #283: Enhances the integration of homescreen functionality, directly related to the modifications in the register_homescreen_app method.

Poem

🐰 In the workshop where skills do play,
Icons now find their rightful way.
From roots to resources, they hop with glee,
Logging errors, as bright as can be!
A homescreen app, so neat and bright,
Thanks to the changes, all feels just right! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 51.61%. Comparing base (7c02206) to head (7dcc59b).
Report is 127 commits behind head on dev.

Files with missing lines	Patch %	Lines
ovos_workshop/skills/ovos.py	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #285      +/-   ##
==========================================
- Coverage   53.41%   51.61%   -1.81%     
==========================================
  Files          37       36       -1     
  Lines        4362     4315      -47     
==========================================
- Hits         2330     2227     -103     
- Misses       2032     2088      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.