fix/featured_media

[JarbasAl]

needs to serialize MediaEntry to dict before emitting bus message

Summary by CodeRabbit

• Bug Fixes
  • Ensured consistency in data structure by converting specific objects to dictionaries before updating them. This enhances reliability when handling media entries, playlists, and plugin streams.

[coderabbitai]

Walkthrough

The changes involve updating elements within a loop, adding a conditional check to convert specific types (MediaEntry, Playlist, PluginStream) to dictionaries before modifying them. This ensures consistent data structures by injecting skill_id into each result appropriately.

Changes

File	Change Summary
ovos_workshop/skills/common_play.py	Added conditional checks to convert certain objects (MediaEntry, Playlist, PluginStream) to dictionaries (as_dict) and then inject skill_id into each result.

Poem

In loops we tread, with code so tight,
Converting types to make things right.
Media, Playlist, all in line,
Dictionaries now, skill_id we define.
🎶 Our data flows, robust and clear,
With every skill, we hold dear.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between cbad3e0 and c573300.

Files selected for processing (1)

• ovos_workshop/skills/common_play.py (1 hunks)

Additional comments not posted (1)

ovos_workshop/skills/common_play.py (1)

537-538: Ensure consistent data structure before emitting bus messages.

The changes correctly serialize MediaEntry, Playlist, and PluginStream objects into dictionaries before they are used in a bus message. This ensures that the data structure remains consistent and compatible with the expected format for bus communications.