Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/wrong_log_due_identation_error #223

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

JarbasAl
Copy link
Member

an error log was always logged on success instead of on failure due to an indentation error

2024-07-11 22:20:17.923 - skills - ovos_workshop.skills.common_play:__handle_ocp_query:491 - DEBUG - skipping skill-ovos-youtube-music.openvoiceos, it does not support media type: 2

an error log was always logged on success instead of on failure due to an identation error
@JarbasAl JarbasAl added the bug Something isn't working label Jul 11, 2024
@JarbasAl JarbasAl requested review from mikejgray and a team July 11, 2024 20:53
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev@8869c2d). Learn more about missing BASE report.

Files Patch % Lines
ovos_workshop/skills/common_play.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #223   +/-   ##
======================================
  Coverage       ?   53.18%           
======================================
  Files          ?       37           
  Lines          ?     4266           
  Branches       ?        0           
======================================
  Hits           ?     2269           
  Misses         ?     1997           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl force-pushed the fix/wrong_log_due_identation_error branch from 2d5eab0 to bfd7f51 Compare July 11, 2024 21:43
@JarbasAl JarbasAl merged commit 2b73bcb into dev Jul 11, 2024
17 checks passed
@JarbasAl JarbasAl deleted the fix/wrong_log_due_identation_error branch July 11, 2024 21:43
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants