Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/skillmanager_api #222

Merged
merged 1 commit into from
Jul 16, 2024
Merged

fix/skillmanager_api #222

merged 1 commit into from
Jul 16, 2024

Conversation

JarbasAl
Copy link
Member

compat with skillmanager.activate/deactivate/keep api for standalone skills

closes #204

skillmanager.list needs to be solved in ovos-core side

compat with skillmanager.activate/deactivate/keep api for standalone skills

closes #204

skillmanager.list needs to be solved in ovos-core side
@JarbasAl JarbasAl added the bug Something isn't working label Jul 11, 2024
@JarbasAl JarbasAl requested review from goldyfruit and a team July 11, 2024 18:50
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 16 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev@8869c2d). Learn more about missing BASE report.

Files Patch % Lines
ovos_workshop/skill_launcher.py 11.11% 16 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #222   +/-   ##
======================================
  Coverage       ?   53.01%           
======================================
  Files          ?       37           
  Lines          ?     4284           
  Branches       ?        0           
======================================
  Hits           ?     2271           
  Misses         ?     2013           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit d945fd2 into dev Jul 16, 2024
9 checks passed
@JarbasAl JarbasAl deleted the fix/skillmanager_api branch July 16, 2024 01:14
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standalone skill and intent.service.skills.(deactivate|activate), skillmanager.list
1 participant