fix/killable_converse #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
similarly to fallback, kill converse handlers forcibly if they time out
JarbasAl
added a commit
to OpenVoiceOS/ovos-core
that referenced
this pull request
Jul 11, 2024
similarly to fallback, kill converse handlers forcibly if they time out companion to OpenVoiceOS/OVOS-workshop#221
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #221 +/- ##
======================================
Coverage ? 52.98%
======================================
Files ? 37
Lines ? 4286
Branches ? 0
======================================
Hits ? 2271
Misses ? 2015
Partials ? 0 ☔ View full report in Codecov by Sentry. |
(end2end tested in ovos-core companion PR)
JarbasAl
added a commit
to OpenVoiceOS/ovos-core
that referenced
this pull request
Jul 16, 2024
* fix/killable_converse similarly to fallback, kill converse handlers forcibly if they time out companion to OpenVoiceOS/OVOS-workshop#221 * end2end test killing of get_response/converse * requirements.txt
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similarly to fallback, kill converse handlers forcibly if they time out