Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/ocp_skill_name_from_voc #220

Merged
merged 2 commits into from
Jul 11, 2024
Merged

feat/ocp_skill_name_from_voc #220

merged 2 commits into from
Jul 11, 2024

Conversation

JarbasAl
Copy link
Member

solve TODO, allow devs to specify a .voc file with skill name strings, instead of deriving from class name

solve TODO, allow devs to specify a .voc file with skill name strings, instead of deriving from class name
@JarbasAl JarbasAl added the enhancement New feature or request label Jul 11, 2024
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 15.38462% with 11 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev@3b7ab46). Learn more about missing BASE report.

Files Patch % Lines
ovos_workshop/skills/common_play.py 15.38% 11 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #220   +/-   ##
======================================
  Coverage       ?   53.18%           
======================================
  Files          ?       37           
  Lines          ?     4266           
  Branches       ?        0           
======================================
  Hits           ?     2269           
  Misses         ?     1997           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

solve TODO, allow devs to specify a .voc file with skill name strings, instead of deriving from class name
@JarbasAl JarbasAl merged commit b46a893 into dev Jul 11, 2024
9 checks passed
@JarbasAl JarbasAl deleted the feat/ocp_skill_name_from_voc branch July 11, 2024 18:37
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant