Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix/undeclared_variable #219

Merged
merged 1 commit into from
Jun 30, 2024
Merged

hotfix/undeclared_variable #219

merged 1 commit into from
Jun 30, 2024

Conversation

JarbasAl
Copy link
Member

noticed in core unittests

noticed in core unittests
@JarbasAl JarbasAl added the bug Something isn't working label Jun 30, 2024
@JarbasAl JarbasAl requested review from goldyfruit, mikejgray and a team June 30, 2024 19:37
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev@b9a1561). Learn more about missing BASE report.

Files Patch % Lines
ovos_workshop/skills/common_play.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev     #219   +/-   ##
======================================
  Coverage       ?   53.27%           
======================================
  Files          ?       37           
  Lines          ?     4257           
  Branches       ?        0           
======================================
  Hits           ?     2268           
  Misses         ?     1989           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JarbasAl JarbasAl merged commit e10738c into dev Jun 30, 2024
9 checks passed
@JarbasAl JarbasAl deleted the hotfix/undeclared_var branch June 30, 2024 19:43
@github-actions github-actions bot mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants